Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow opt-in with wasm engine #650

Open
srenatus opened this issue Aug 9, 2021 · 3 comments
Open

allow opt-in with wasm engine #650

srenatus opened this issue Aug 9, 2021 · 3 comments

Comments

@srenatus
Copy link
Collaborator

srenatus commented Aug 9, 2021 •
edited
Loading

Right now, the opa-envoy-plugin is configured to use exactly one query, and it's caching the prepare eval state. It should be possible to use wasm instead of the rego target.

It may be worthwhile to re-run some benchmarks to compare rego vs wasm in the envoy scenario.

💭 Note that this has nothing to do with running the wasm modules that OPA can compile a policy to in envoy directly. While very neat, that's another issue (#3235). This one should be a much lower-hanging fruit.
@srenatus
Copy link
Collaborator Author

srenatus commented Aug 9, 2021

Started playing with this a bit here -- but I've stumbled upon the inter query builtin cache, and I'm currently not sure how that's handled in Wasm 🤔 🔍

srenatus referenced this issue in srenatus/opa Aug 9, 2021
@srenatus
rego: pass inter-query builtin cache to wasm sdk
1922ee0 
Found when looking into #3716.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Signed-off-by: Stephan Renatus <[email protected]>
This was referenced Aug 9, 2021
Merged
Closed
srenatus referenced this issue in open-policy-agent/opa Aug 9, 2021
@srenatus
rego: pass inter-query builtin cache to wasm sdk (#3721)
47d1cb6 
Found when looking into #3716.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Signed-off-by: Stephan Renatus <[email protected]>
@srenatus
Copy link
Collaborator Author

ℹ️ this will now need to account for open-policy-agent/opa#3708

jgchn referenced this issue in jgchn/opa Aug 20, 2021
@srenatus @jgchn
rego: pass inter-query builtin cache to wasm sdk (open-policy-agent#3721
cd35ac3 
)

Found when looking into #3716.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Signed-off-by: Stephan Renatus <[email protected]>
@srenatus srenatus changed the title opa-envoy-plugin: all opt-in with wasm engine opa-envoy-plugin: allow opt-in with wasm engine Aug 27, 2021
srenatus referenced this issue in srenatus/opa-istio-plugin Sep 13, 2021
@srenatus
plugin: allow selecting wasm target for evaluation
ac0d67f 
This turns the simple grpc tests scenario into a matrix test for both
evaluation variants.

Fixes open-policy-agent/opa#3716.

Signed-off-by: Stephan Renatus <[email protected]>
srenatus referenced this issue in srenatus/opa-istio-plugin Sep 27, 2021
@srenatus
plugin: allow selecting wasm target for evaluation
62e3947 
This turns the simple grpc tests scenario into a matrix test for both
evaluation variants.

Fixes open-policy-agent/opa#3716.

Signed-off-by: Stephan Renatus <[email protected]>
dolevf referenced this issue in dolevf/opa Nov 4, 2021
@srenatus @dolevf
rego: pass inter-query builtin cache to wasm sdk (open-policy-agent#3721
4dd4581 
)

Found when looking into #3716.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Dolev Farhi <[email protected]>
@stale
Copy link

stale bot commented Nov 22, 2021

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

@anderseknert anderseknert transferred this issue from open-policy-agent/opa Jan 20, 2025
@srenatus srenatus changed the title opa-envoy-plugin: allow opt-in with wasm engine allow opt-in with wasm engine Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugin: allow selecting wasm target for evaluation srenatus/opa-istio-plugin
1 participant
@srenatus