change 'data will be added' from Info to Debug to be less spammy#482
Merged
Conversation
Contributor
|
LGTM, but needs DCO |
grosser
force-pushed
the
grosser/debug
branch
from
2f607c9 to
06bb49d
Compare
Contributor
Author
|
done! :) |
maxsmythe
reviewed
Feb 19, 2020
| } | ||
|
|
||
| r.log.Info("data will be added", "data", instance) | ||
| r.log.Debug("data will be added", "data", instance) |
Contributor
There was a problem hiding this comment.
It looks like .Debug() doesn't exist.
We could add a global constant DebugLevel to pkg/logging/logging.go with the value of 2, then change this to:
r.log.V(logging.DebugLevel).Info(<ORIGNAL ARGS>)
Contributor
Author
There was a problem hiding this comment.
this seems like a really strange logger if basic things like Debug don't exist :(
Contributor
There was a problem hiding this comment.
Yeah, unclear to me why it's structured that way, it seems like something that'd be intentional though.
grosser
force-pushed
the
grosser/debug
branch
from
06bb49d to
7515777
Compare
syncing happens a lot, especially when watching many resources and the constant "data will be added" spam is only needed when "debugging" sync issues, so change to debug Signed-off-by: Michael Grosser <michael@grosser.it>
grosser
force-pushed
the
grosser/debug
branch
from
7515777 to
0ab7ec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syncing happens a lot, especially when watching many resources and the constant "data will be added"
spam is only needed when "debugging" sync issues, so change to debug
fixes #399
@maxsmythe