fix: helm probe webhook retry logic#2873
Merged
Merged
Conversation
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com>
JaydipGabani
approved these changes
Jul 13, 2023
Contributor
JaydipGabani
left a comment
JaydipGabani
left a comment
There was a problem hiding this comment.
Thanks for raising the PR!
sozercan
reviewed
Jul 17, 2023
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com>
ritazh
approved these changes
Jul 19, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2873 +/- ##
==========================================
+ Coverage 53.53% 53.61% +0.07%
==========================================
Files 133 133
Lines 11545 11545
==========================================
+ Hits 6181 6190 +9
+ Misses 4887 4880 -7
+ Partials 477 475 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
--retry-connrefusedflag to the curl command in the Gatekeeper post-install webhookWhich issue(s) this PR fixes:
Fixes #2872