This repository was archived by the owner on May 27, 2026. It is now read-only.
fix: gha workflows#16
Merged
Merged
Conversation
mrjoelkamp
force-pushed
the
fix-gha-workflows
branch
from
ac5ec8e to
2e2b9b5
Compare
mrjoelkamp
force-pushed
the
fix-gha-workflows
branch
from
6ad3d0d to
9edce85
Compare
mrjoelkamp
force-pushed
the
fix-gha-workflows
branch
2 times, most recently
from
57d87dd to
e8715a8
Compare
mrjoelkamp
force-pushed
the
fix-gha-workflows
branch
from
e8715a8 to
9797d27
Compare
mrjoelkamp
force-pushed
the
fix-gha-workflows
branch
2 times, most recently
from
d1edbeb to
3b0667d
Compare
mrjoelkamp
force-pushed
the
fix-gha-workflows
branch
from
3b0667d to
cc8881e
Compare
mrjoelkamp
commented
Jun 10, 2024
| wait_for_process ${WAIT_TIME} ${SLEEP_TIME} "kubectl -n ${GATEKEEPER_NAMESPACE} wait --for=condition=Ready --timeout=60s pod -l run=external-data-provider" | ||
| @test "attest-provider is running" { | ||
| wait_for_process ${WAIT_TIME} ${SLEEP_TIME} "kubectl -n ${GATEKEEPER_NAMESPACE} wait --for=condition=Ready --timeout=60s pod -l run=attest-provider" | ||
| sleep 5 # we need a readiness probe https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-readiness-probes |
Contributor
Author
There was a problem hiding this comment.
I added sleep 5 because the attest provider app isn't ready to accept connections immediately after starting, we need to add a readiness probe to the application so that we avoid error: connection refused responses
whalelines
reviewed
Jun 10, 2024
Comment on lines
+47
to
+48
| app-id: ${{ vars.DOCKER_READ_APP_ID }} | ||
| private-key: ${{ secrets.DOCKER_READ_APP_PRIVATE_KEY }} |
Comment on lines
-31
to
+32
| run kubectl apply -f validation/external-data-provider-constraint.yaml | ||
| run kubectl apply -f validation/attest-constraint.yaml |
There was a problem hiding this comment.
Did this file get renamed in a previous PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary