ci: remove kubebuilder dependency#2524
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
f6a84c0 to
a76c692
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2524 +/- ##
==========================================
+ Coverage 53.92% 54.01% +0.09%
==========================================
Files 116 116
Lines 10287 10287
==========================================
+ Hits 5547 5557 +10
+ Misses 4314 4307 -7
+ Partials 426 423 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/benchmark |
|
This PR compares its performance to the latest released version. If it performs significantly lower, consider optimizing your changes to improve the performance. |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
…r into ci-remove-kubebuilder
| --build-arg KUBEBUILDER_VERSION=$(KUBEBUILDER_VERSION) | ||
| --build-arg KUSTOMIZE_VERSION=$(KUSTOMIZE_VERSION) | ||
|
|
||
| ## Location to install dependencies to |
There was a problem hiding this comment.
fyi, I can see make test work locally on this fork now 🥇 ; thanks for fixing this !!
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, same comments about "bin"
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
|
@maxsmythe |
* remove kubebuilder dependency Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * remove unused package Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * pin setup-envtest Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * use .tmp/bin Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan sozercan@gmail.com
What this PR does / why we need it:
migrate to envtest and remove kubebuilder dependency
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: