ci: remove kubebuilder dependency#279
Conversation
sozercan
force-pushed
the
ci-remove-kubebuilder
branch
2 times, most recently
from
c26d392 to
376db8d
Compare
|
GK test should succeed after open-policy-agent/gatekeeper#2524 is merged |
| name: "Unit test" | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| timeout-minutes: 10 |
There was a problem hiding this comment.
hm, did you notice an increase in timeouts?
There was a problem hiding this comment.
yes, i added -race -bench to align with GK which increased the timeouts (mostly due to benchmarks)
There was a problem hiding this comment.
the reason we added is to make sure to run benchmarks often so we don't break them
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
force-pushed
the
ci-remove-kubebuilder
branch
from
376db8d to
bed205d
Compare
| --build-arg KUSTOMIZE_VERSION=$(KUSTOMIZE_VERSION) | ||
|
|
||
| ## Location to install dependencies to | ||
| LOCALBIN ?= $(shell pwd)/bin |
There was a problem hiding this comment.
If a user runs this in their source code directory, this will create a /bin folder. Do we want to put this in an easy-to-clean subdir (.output or similar)? Is the /bin directory part of .gitignore?
There was a problem hiding this comment.
looks like bin would be ignored, though I'd personally consider putting this in a .output directory to make it easy to wipe everything and start from zero.
There was a problem hiding this comment.
@maxsmythe bin is the default for kubebuilder v3 and it's in gitignore. looks like we are using .tmp already (for linter) so i changed to .tmp/bin
| --build-arg KUSTOMIZE_VERSION=$(KUSTOMIZE_VERSION) | ||
|
|
||
| ## Location to install dependencies to | ||
| LOCALBIN ?= $(shell pwd)/bin |
There was a problem hiding this comment.
looks like bin would be ignored, though I'd personally consider putting this in a .output directory to make it easy to wipe everything and start from zero.
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov ReportBase: 49.30% // Head: 49.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 49.30% 49.30%
=======================================
Files 69 69
Lines 4468 4468
=======================================
Hits 2203 2203
Misses 2021 2021
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
Sorry, I thought I LGTMd this after verifying bin was git-ignored (meant that to be a nit)
|
It looks like the tests are now failing. If moving the binaries makes it harder to start the control plane, let's just use the vanilla location. |
4 participants
Signed-off-by: Sertac Ozercan sozercan@gmail.com