Skip to content

fix(helm): Fix "Label exempted namespaces" #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritazh merged 2 commits into from
Sep 30, 2022
Merged

fix(helm): Fix "Label exempted namespaces" #2290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f37350a
Fix the RBAC for labeling namespace for post upgrade job
ZhiminXiang Sep 27, 2022
98893c8
Merge branch 'master' into post-upgrade-job-rbac
ZhiminXiang Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/build/helmify/static/templates/namespace-post-upgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ metadata:
---
{{- if .Values.rbac.create }}
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
kind: ClusterRole
metadata:
name: gatekeeper-update-namespace-label-post-upgrade
labels:
Expand Down Expand Up @@ -101,7 +101,7 @@ rules:
---
{{- if .Values.rbac.create }}
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
kind: ClusterRoleBinding
metadata:
name: gatekeeper-update-namespace-label-post-upgrade
labels:
Expand All @@ -113,7 +113,7 @@ metadata:
"helm.sh/hook-delete-policy": hook-succeeded,before-hook-creation
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
kind: ClusterRole
name: gatekeeper-update-namespace-label-post-upgrade
subjects:
- kind: ServiceAccount
Expand Down
6 changes: 3 additions & 3 deletions manifest_staging/charts/gatekeeper/templates/namespace-post-upgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ metadata:
---
{{- if .Values.rbac.create }}
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
kind: ClusterRole
metadata:
name: gatekeeper-update-namespace-label-post-upgrade
labels:
Expand Down Expand Up @@ -101,7 +101,7 @@ rules:
---
{{- if .Values.rbac.create }}
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
kind: ClusterRoleBinding
metadata:
name: gatekeeper-update-namespace-label-post-upgrade
labels:
Expand All @@ -113,7 +113,7 @@ metadata:
"helm.sh/hook-delete-policy": hook-succeeded,before-hook-creation
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
kind: ClusterRole
name: gatekeeper-update-namespace-label-post-upgrade
subjects:
- kind: ServiceAccount
Expand Down