fix(helm): Fix "Label exempted namespaces" #2290
Merged
ritazh merged 2 commits intoSep 30, 2022
Merged
Conversation
ZhiminXiang
force-pushed
the
post-upgrade-job-rbac
branch
from
04ea2a4 to
e643c84
Compare
Codecov ReportBase: 53.32% // Head: 53.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2290 +/- ##
==========================================
+ Coverage 53.32% 53.43% +0.10%
==========================================
Files 116 116
Lines 10174 10174
==========================================
+ Hits 5425 5436 +11
+ Misses 4327 4319 -8
+ Partials 422 419 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ZhiminXiang
force-pushed
the
post-upgrade-job-rbac
branch
2 times, most recently
from
57bd5b1 to
81f8bf9
Compare
Signed-off-by: Zhimin Xiang <xiangzhimin1010@gmail.com>
ZhiminXiang
force-pushed
the
post-upgrade-job-rbac
branch
from
81f8bf9 to
f37350a
Compare
Contributor
Author
|
/cc @ritazh |
maxsmythe
approved these changes
Sep 30, 2022
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar like #2246, we will need to fix the RBAC for the post upgrade job.