feat: Expose options to allow injection of external certificates#2249
Merged
ritazh merged 5 commits intoSep 2, 2022
Merged
Conversation
* Allow overriding the certificate secret name * Only generate cert-secret if external injection is disabled * Disable default certificate rotation when injecting Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2249 +/- ##
==========================================
+ Coverage 54.49% 54.57% +0.07%
==========================================
Files 111 111
Lines 9556 9556
==========================================
+ Hits 5208 5215 +7
+ Misses 3947 3942 -5
+ Partials 401 399 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
|
Hi, I'm away for a while from next week onwards - if someone has a chance to review this before the weekend that'd be great - I can then make any changes requested before I leave. No worries if not, I can handle it upon my return. |
Contributor
ritazh
approved these changes
Sep 1, 2022
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is very similar to #1359 by @romachalm which was unfortunately never merged as the author stopped responding. I had followed the same path, implementing webhook annotations in #2231 before stumbling across this PR. I have recreated this with a slightly different interface.
This PR allows for external certificates to be injected and used in place of the default, self signed certificate. This is useful when using services such as
cert-managerto automatically sign and rotate certificates. It provides Helm chart config values which when set:This, in combination with the annotations in #2231 allows for configuring external certificate injection
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #520
Special notes for your reviewer:
N/A