feat(helm): Allow setting annotations for mutating and validating webhook configurations#2231
Merged
ritazh merged 5 commits intoAug 20, 2022
Conversation
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2231 +/- ##
==========================================
+ Coverage 54.33% 54.43% +0.10%
==========================================
Files 111 111
Lines 9538 9538
==========================================
+ Hits 5182 5192 +10
+ Misses 3956 3949 -7
+ Partials 400 397 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi, if anyone has a chance to review this that'd be great. Thanks :) |
ritazh
approved these changes
Aug 19, 2022
This was referenced Aug 26, 2022
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged): This PR allows for the annotations for theMutatingWebhookConfigurationandValidatingWebhookConfigurationto be set through the chart. Allows for certificate injection withcert-manager(See https://cert-manager.io/docs/concepts/ca-injector/)Special notes for your reviewer:
N/A