Skip to content

Conversation

@jsquyres
Copy link
Member

@jsquyres jsquyres commented Nov 3, 2021

Reverts #9609

bot:notacherrypick

@gpaulsen
Copy link
Member

gpaulsen commented Nov 3, 2021

@jsquyres Can you please add some rational for reverting #9609? I'm not familiar with the issue, and it'd be good to document here.

@gpaulsen
Copy link
Member

gpaulsen commented Nov 3, 2021

Ah, rational on #9609

@ggouaillardet
Copy link
Contributor

@gpaulsen the issue on the latest official releases were already and correctly fixed (see 952328c3827). moreover, this PR on top of the right fix breaks the wrappers(!)

@awlauria
Copy link
Contributor

awlauria commented Nov 3, 2021

Looks like this is missing the sign-off.

@jsquyres
Copy link
Member Author

jsquyres commented Nov 3, 2021

It's a revert, and the git commit cherry picker ignores reverts in terms of needing a signoff.

It failed the git commit cherry picker because I neglected to include bot:notacherrypick in the PR description. Fixed.

@bwbarrett bwbarrett merged commit e87540f into v4.1.x Nov 3, 2021
@jsquyres jsquyres deleted the revert-9609-topic/orted_mpir branch November 3, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants