add libopen-orted-mpir when statically linking

[ggouaillardet]

This is a one-off commit for the v4 series since
v5 and later moved to prrte.
bot:notacherrypick

Thanks Matt Thompson for reporting this issue.

Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp

[ggouaillardet]

@rhc54 could you please have a look at this PR?

Currently, if Open MPI is configure'd with --enable-static --disable-shared, linking a simple MPI program fails because some MPIR_* symbols are missing. This PR addresses that by adding libopen-orted-mpir to the list of static libs, but I am not quite sure if this is the right fix.

[rhc54]

I'm not the correct person - haven't had anything to do with MPIR in ages.

@awlauria I think you folks deal with this now?

[awlauria]

The change makes sense to me. @jsquyres / @gpaulsen / @bwbarrett ?

[hppritcha]

@ggouaillardet would you mind opening an equivalent PR for the v4.0.x series?

[jsquyres]

@bwbarrett This looks correct to me. Can you think of any problems with it?

[bwbarrett]

I can't think of anything; it raises the question why we're leaving it in a standalone library, but let's not worry about that for now.

[awlauria]

It was compiled into its stand-alone library to compile it with its own CFLAGS, otherwise they would be compiled with -O3 and the like:

#8428

[ggouaillardet]

the PR for the v4.0.x series is in #9618

[ggouaillardet]

@awlauria thanks for the insight.
is there any reason why this library was not slurped into libopen-rte (instead of being a dependency)?

[ggouaillardet]

@awlauria @bwbarrett I think I understand ... and I messed up (!)

the library used to be installed, but is now slurped (aka noinst) since 952328c3827

that means this PR should be reverted (!)

do you concur?

[jsquyres]

Ah shoot. Yes, there's the reason this PR shouldn't have been merged. Oh well; let's revert...

[jsquyres]

FWIW, I confirm with my own local build that the v4.1.x branch is now broken:

mpicc -g  hello_c.c  -o hello_c
/usr/bin/ld: cannot find -lopen-orted-mpir
collect2: error: ld returned 1 exit status

Why didn't CI catch this? Weird.

[bwbarrett]

I'm not sure why CI didn't catch this. I'll dig into that; very weird.

[ggouaillardet]

The issue only occurs if Open MPI is configured with --disable-shared --enable-static and a MPI wrapper is used. Not sure CI tests this.