v5.0.x: ompi/group: fix proc pointer comparison in groups#8613
Closed
gpaulsen wants to merge 3 commits intoopen-mpi:masterfrom
Closed
v5.0.x: ompi/group: fix proc pointer comparison in groups#8613gpaulsen wants to merge 3 commits intoopen-mpi:masterfrom
gpaulsen wants to merge 3 commits intoopen-mpi:masterfrom
Conversation
There already exists an identifier with the name assert. It is not appropriate to use this name for variables in C. This commit changes these variable names to mpi_assert. This should address an issue where clang-format gives the wrong result when doing bit-wise-and operations on these variables. Signed-off-by: Nathan Hjelm <hjelmn@google.com> (cherry picked from commit aaabe3d)
…ll_things_DO_NOT_NAME_VARIABLES_ASSERT v5.0.x: ompi: rename assert variables to mpi_assert
To avoid checking sentinel process pointers to the original `ompi_proc_t` pointers compare the processes in the groups using process names. Signed-off-by: Aboorva Devarajan <abodevar@in.ibm.com> (cherry picked from commit 0f2c70c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid checking sentinel process pointers to the original ompi_proc_t
pointers compare the processes in the groups using process names.
From master PR #8547