v5.0.x: ompi: rename assert variables to mpi_assert#8594
Merged
gpaulsen merged 1 commit intoopen-mpi:v5.0.xfrom Mar 15, 2021
Merged
Conversation
There already exists an identifier with the name assert. It is not appropriate to use this name for variables in C. This commit changes these variable names to mpi_assert. This should address an issue where clang-format gives the wrong result when doing bit-wise-and operations on these variables. Signed-off-by: Nathan Hjelm <hjelmn@google.com> (cherry picked from commit aaabe3d)
awlauria
changed the title
gpaulsen
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There already exists an identifier with the name assert. It is not
appropriate to use this name for variables in C. This commit changes
these variable names to mpi_assert. This should address an issue where
clang-format gives the wrong result when doing bit-wise-and operations
on these variables.
Signed-off-by: Nathan Hjelm hjelmn@google.com
(cherry picked from commit aaabe3d)