fs/lustre: Remove unneeded includes#8512
Merged
edgargabriel merged 1 commit intoopen-mpi:masterfrom Feb 23, 2021
Merged
Conversation
Member
Author
|
Can a maintainer please label this PR appropriately, also for the backports to |
edgargabriel
approved these changes
Feb 23, 2021
Member
|
@bertwesarg would you like to commit this or shall I go and press the button? |
Member
|
ok to test |
Member
Author
I do not have the permissions. I also would like to fix a typo in the commit message |
The functionality was migrated to `fs/base/fs_base_get_parent_dir.c` long ago, but the includes stayed. Though in lustre 2.14 `lustre_user.h` moved the inclusion of `linux/fs.h` outside the `__KERNEL__` guard. This triggered now Debian bug #898743 [1], which states that including `sys/mount.h` after `linux/fs.h` breaks compilation. Thus the include removal also avoids this breakage. Closes open-mpi#8508. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898743 Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de>
bertwesarg
force-pushed
the
fix-lustre-2.14
branch
from
41bb147 to
5b525b2
Compare
Member
|
bot:ompi:retest |
Member
|
I will create the pr's for the 4.0 and 4.1 branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality was migrated to
fs/base/fs_base_get_parent_dir.clongago, but the includes stayed. Though with lustre 2.14 the
lustre_uer.hmoved its include from
linux/fs.houtside the__KERNEL__guard. Thisnow triggered the Debian bug #898743 [1], which states that including
sys/mount.hafterlinux/fs.hbreaks compilation. Thus the includeremoval also avoids this breakage.
Closes #8508.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898743
Signed-off-by: Bert Wesarg bert.wesarg@tu-dresden.de