Skip to content

add patch to fix MS_RDONLY error in OpenMPI 4.0.5#19837

Merged
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20240212164635_new_pr_OpenMPI405
Feb 26, 2024
Merged

add patch to fix MS_RDONLY error in OpenMPI 4.0.5#19837
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20240212164635_new_pr_OpenMPI405

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 12, 2024

(created using eb --new-pr)

This fixes a known issue fixed in OpenMPI 4.0.5 by using the upstream fix as a patch:

In file included by /usr/include/linux/fs.h:18,
                 by /usr/include/linux/lustre/lustre_user.h:57,
                 by /usr/include/lustre/lustreapi.h:47,
                 by ../../../../ompi/mca/fs/lustre/fs_lustre.h:37,
                 by fs_lustre.c:33:
/usr/include/sys/mount.h:35:3: Error: expected identifier before numeric constant
   35 |   MS_RDONLY = 1,  /* Mount read-only.  */
      |   ^~~~~~~~~
make[2]: *** [Makefile:1866: fs_lustre.lo] Error 1

See open-mpi/ompi#8512

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 10 out of 10 (3 easyconfigs in total)
n1539 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/c695c071894b32576fd3decf435c0045 for a full test report.

@Micket Micket added the bug fix label Feb 13, 2024
@Micket Micket added this to the release after 4.9.0 milestone Feb 13, 2024
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 20, 2024

@boegelbot please test @ generoso
EB_ARGS="OpenMPI-4.0.5-GCC-10.2.0.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=19837 EB_ARGS="OpenMPI-4.0.5-GCC-10.2.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19837 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12928

Test results coming soon (I hope)...

Details

- notification for comment with ID 1954725781 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/465b7f495817e87fdcc336cbb06204ab for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 26, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit 7826aea into easybuilders:develop Feb 26, 2024
@Flamefire Flamefire deleted the 20240212164635_new_pr_OpenMPI405 branch February 27, 2024 08:06
@boegel boegel changed the title fix MS_RDONLY error in OpenMPI 4.0.5 add patch to fix MS_RDONLY error in OpenMPI 4.0.5 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants