-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add AddHandler extension method to Dependency Injection package #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
askpt
merged 11 commits into
open-feature:main
from
kylejuliandev:feat/add-eventhandler-via-dependencyinjection
May 12, 2025
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e713451
Add extension method for adding Handler via Dependency Injection
kylejuliandev 1a4e979
Add unit tests for new Extension method
kylejuliandev 51acc27
Update README and add examples for injecting Handlers
kylejuliandev 0fd4057
Swap to use Guid.NewGuid() instead of random string generator
kylejuliandev e439ab1
Address PR comments
kylejuliandev 9f5de5c
Merge remote-tracking branch 'origin/main' into feat/add-eventhandler…
kylejuliandev 2172948
Address PR comments
kylejuliandev cd44977
Adopt Guard.ThrowIfNullOrWhiteSpace
kylejuliandev 9b7268e
Update integration tests
kylejuliandev 550d245
Remove unnecessary using statements
kylejuliandev 51645c2
Remove AddHandler with name extension methods
kylejuliandev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/OpenFeature.DependencyInjection/Internal/EventHandlerDelegateWrapper.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| using OpenFeature.Constant; | ||
| using OpenFeature.Model; | ||
|
|
||
| namespace OpenFeature.DependencyInjection.Internal; | ||
|
|
||
| internal record EventHandlerDelegateWrapper | ||
| { | ||
| public ProviderEventTypes ProviderEventType { get; } | ||
|
|
||
| public EventHandlerDelegate EventHandlerDelegate { get; } | ||
|
|
||
| public EventHandlerDelegateWrapper(ProviderEventTypes providerEventTypes, EventHandlerDelegate eventHandlerDelegate) | ||
| { | ||
| ProviderEventType = providerEventTypes; | ||
| EventHandlerDelegate = eventHandlerDelegate; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.