feat: add AddHandler extension method to Dependency Injection package #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

askpt merged 11 commits into open-feature:main from kylejuliandev:feat/add-eventhandler-via-dependencyinjection

May 12, 2025

Contributor

kylejuliandev commented May 7, 2025 •

edited

Loading

This PR

Introduces a new extension method in the OpenFeature.DependencyInjection package which allows consumers to add, at a global/api level, a handler.

Example usage:

builder.Services.AddOpenFeature(feature =>
{
    feature.AddHostedFeatureLifecycle()
        .AddInMemoryProvider()
        .AddHandler(ProviderEventTypes.ProviderReady, (@event) => { Console.WriteLine("{0}", @event!.ProviderName); })
        .AddHandler(ProviderEventTypes.ProviderReady, sp => (@event) =>
        {
            var logger = sp.GetRequiredService<ILogger<Program>>();
            logger.LogInformation("Provider Ready");
        });
});

Related Issues

Fixes #457

Notes

Follow-up Tasks

How to test

kylejuliandev added 3 commits

May 7, 2025 19:48


          Add extension method for adding Handler via Dependency Injection

e713451

Signed-off-by: Kyle Julian <[email protected]>


          Add unit tests for new Extension method

1a4e979

Signed-off-by: Kyle Julian <[email protected]>


          Update README and add examples for injecting Handlers

51acc27

Signed-off-by: Kyle Julian <[email protected]>

kylejuliandev requested a review from a team as a code owner

May 7, 2025 19:24

codecov bot commented May 7, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (0a5ab0c) to head (51645c2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   86.72%   86.87%   +0.14%     
==========================================
  Files          42       43       +1     
  Lines        1703     1722      +19     
  Branches      179      180       +1     
==========================================
+ Hits         1477     1496      +19     
  Misses        187      187              
  Partials       39       39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

beeme1mr approved these changes

View reviewed changes

Member

beeme1mr left a comment

Looks good to me. I just had a question about the random name generator but it isn't a blocker.

src/OpenFeature.DependencyInjection/OpenFeatureBuilderExtensions.cs Outdated Show resolved Hide resolved

beeme1mr requested review from arttonoyan, askpt, kinyoklion and toddbaert

May 7, 2025 19:49

askpt reviewed

View reviewed changes

Member

askpt left a comment

Looks good to me. Great work. Added a couple of suggestions 👍

src/OpenFeature.DependencyInjection/OpenFeatureBuilderExtensions.cs Outdated Show resolved Hide resolved

src/OpenFeature.DependencyInjection/OpenFeatureBuilderExtensions.cs Outdated Show resolved Hide resolved


          Swap to use Guid.NewGuid() instead of random string generator

0fd4057

* Add check if passed in handler name is an empty or null string

Signed-off-by: Kyle Julian <[email protected]>

askpt reviewed

View reviewed changes

Member

askpt left a comment

It is a very minor request! We should also validate for inputs like whitespace.

Also, @arttonoyan, would you mind double-checking?

src/OpenFeature.DependencyInjection/OpenFeatureBuilderExtensions.cs Outdated Show resolved Hide resolved

test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs Outdated Show resolved Hide resolved

kylejuliandev added 2 commits

May 9, 2025 19:27


          Address PR comments

e439ab1

* Ensure that calling AddHandler multiple times will actually add all
  instances to the underlying OpenFeature API
* Add unit tests to cover this behaviour

Signed-off-by: Kyle Julian <[email protected]>


          Merge remote-tracking branch 'origin/main' into feat/add-eventhandler…

9f5de5c

…-via-dependencyinjection

Signed-off-by: Kyle Julian <[email protected]>

askpt reviewed

View reviewed changes

Member

askpt left a comment

LGTM. Just a minor question, and should be ready to merge! Thanks!

src/OpenFeature.DependencyInjection/OpenFeatureBuilderExtensions.cs Outdated Show resolved Hide resolved

arttonoyan requested changes

View reviewed changes

src/OpenFeature.DependencyInjection/Internal/EventHandlerDelegateWrapper.cs Outdated Show resolved Hide resolved

src/OpenFeature.DependencyInjection/OpenFeatureBuilderExtensions.cs Outdated Show resolved Hide resolved

kylejuliandev added 2 commits

May 9, 2025 22:49


          Address PR comments

* Throw ArgumentException when HandlerName is null or empty
* Use primary constructor in EventHandlerDelegateWrapper

Signed-off-by: Kyle Julian <[email protected]>


          Adopt Guard.ThrowIfNullOrWhiteSpace

cd44977

Signed-off-by: Kyle Julian <[email protected]>

askpt approved these changes

View reviewed changes

Member

askpt commented May 10, 2025

LGTM! If @arttonoyan is happy with the changes @kylejuliandev made, we can merge it 👍
Thanks for your efforts!

arttonoyan reviewed

View reviewed changes

src/OpenFeature.DependencyInjection/Internal/FeatureLifecycleManager.cs Outdated Show resolved Hide resolved

kylejuliandev added 2 commits

May 10, 2025 23:51


          Update integration tests

9b7268e

* Ensure when multiple handlers are registered that they are both
  registered
* Tweak CreateServerAsync to make it easier to extend dependency
  injection tests

Signed-off-by: Kyle Julian <[email protected]>


          Remove unnecessary using statements

550d245

Signed-off-by: Kyle Julian <[email protected]>

arttonoyan reviewed

View reviewed changes

test/OpenFeature.IntegrationTests/FeatureFlagIntegrationTest.cs Show resolved Hide resolved


          Remove AddHandler with name extension methods

51645c2

* Remove any unnecessary unit tests
* Update integration tests to use openFeatureBuilder for easily
  adjusting the Arrange part of each test

Signed-off-by: Kyle Julian <[email protected]>

arttonoyan approved these changes

View reviewed changes

askpt added this pull request to the merge queue

Merged via the queue into open-feature:main with commit ff414b8

18 checks passed

Contributor Author

kylejuliandev commented May 12, 2025

Thank you @askpt @arttonoyan @beeme1mr! This ended up being a code review and API review all in one; I appreciate the collaboration!

kylejuliandev deleted the feat/add-eventhandler-via-dependencyinjection branch

May 12, 2025 07:58

WeihanLi pushed a commit to WeihanLi/openfeature-dotnet-sdk that referenced this pull request


          feat: add AddHandler extension method to Dependency Injection package (…

833c78a

…open-feature#462)

<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- Introduces a new extension method in the
OpenFeature.DependencyInjection package which allows consumers to add,
at a global/api level, a handler.

Example usage:

```csharp
builder.Services.AddOpenFeature(feature =>
{
    feature.AddHostedFeatureLifecycle()
        .AddInMemoryProvider()
        .AddHandler(ProviderEventTypes.ProviderReady, (@event) => { Console.WriteLine("{0}", @event!.ProviderName); })
        .AddHandler(ProviderEventTypes.ProviderReady, sp => (@event) =>
        {
            var logger = sp.GetRequiredService<ILogger<Program>>();
            logger.LogInformation("Provider Ready");
        });
});
```

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

Fixes open-feature#457

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->

---------

Signed-off-by: Kyle Julian <[email protected]>
Signed-off-by: Weihan Li <[email protected]>

kylejuliandev mentioned this pull request

build: migrate to slnx #415

Merged

askpt mentioned this pull request

Investigate flaky test #468

Closed

askpt mentioned this pull request

chore(main): release 2.6.0 #461

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          chore(main): release 2.6.0 (#461)

7cae595

🤖 I have created a release *beep* *boop*
---


##
[2.6.0](v2.5.0...v2.6.0)
(2025-05-23)


### ✨ New Features

* add AddHandler extension method to Dependency Injection package
([#462](#462))
([ff414b8](ff414b8))
* Add Extension Method for adding global Hook via DependencyInjection
([#459](#459))
([9b04485](9b04485))
* Add OTEL compatible telemetry object builder
([#397](#397))
([6c44db9](6c44db9))


### 🧹 Chore

* Cleanup .props file
([#476](#476))
([6d7a535](6d7a535))
* **deps:** update actions/attest-build-provenance action to v2.3.0
([#464](#464))
([0a5ab0c](0a5ab0c))
* **deps:** update codecov/codecov-action action to v5.4.3
([#475](#475))
([fbcf3a4](fbcf3a4))
* **deps:** update github/codeql-action digest to 60168ef
([#463](#463))
([ea76351](ea76351))
* **deps:** update github/codeql-action digest to ff0a06e
([#473](#473))
([af1b20f](af1b20f))
* **deps:** update spec digest to edf0deb
([#474](#474))
([fc3bdfe](fc3bdfe))


### 📚 Documentation

* Add AspNetCore sample app
([#477](#477))
([9742a0d](9742a0d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: André Silva <[email protected]>
Co-authored-by: André Silva <[email protected]>

dependabot bot mentioned this pull request

Bump Grpc.AspNetCore and 9 others maheshkonda/observe-OTel-demo#140

Closed

This was referenced Nov 26, 2025

Bump Grpc.AspNetCore and 13 others Jineshkumar1/opentelemetry-demo#159

Open

Bump Grpc.AspNetCore and 8 others Jineshkumar1/opentelemetry-demo#165

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet