Skip to content

Sync opencraft-release/palm.1 with Upstream 20230807-1691366566 - #569

Merged
yusuf-musleh merged 1 commit into
opencraft-release/palm.1from
sync-open-release/palm.master-20230807-1691366566
Aug 10, 2023
Merged

Sync opencraft-release/palm.1 with Upstream 20230807-1691366566#569
yusuf-musleh merged 1 commit into
opencraft-release/palm.1from
sync-open-release/palm.master-20230807-1691366566

Conversation

@opencraft-requirements-bot

Copy link
Copy Markdown

Syncing opencraft-release/palm.1 with Upstream

Important❗

Please always use the "Create a merge commit" option as it avoids issues when checking diffs with upstream.

Note on Conflicts ⚠️

In cases of conflicts you can go ahead and resolve it here on Github if it is simple enough. However if it is a more complicated conflict please follow the steps below:

  1. Check out sync-open-release/palm.master-20230807-1691366566 locally:
  2. Pull latest changes from opencraft-release/palm.1 into that branch, make sure your [REMOTE] is pointing to opencraft-release/palm.1:
git pull [REMOTE] opencraft-release/palm.1
  1. Resolve the conflicts locally, then commit the result. This will create a new merge commit.
  2. Push the new merge commit to sync-open-release/palm.master-20230807-1691366566 to update this PR
  3. Review the PR again and merge when ready!
    Note: Please use the "Create a merge commit" option as it avoids issues when checking diffs with upstream.

@yusuf-musleh

Copy link
Copy Markdown

@Agrendalath This PR looks fine to me, just wanted to check if I should I go ahead and update/merge it?

@Agrendalath Agrendalath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh, sure, feel free to merge this.

@yusuf-musleh
yusuf-musleh force-pushed the sync-open-release/palm.master-20230807-1691366566 branch from 085987e to 448295f Compare August 10, 2023 14:21
@yusuf-musleh
yusuf-musleh merged commit 8c1ed2c into opencraft-release/palm.1 Aug 10, 2023
@yusuf-musleh
yusuf-musleh deleted the sync-open-release/palm.master-20230807-1691366566 branch August 10, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants