fix: discussion errors in the demo course for Palm - #32464
Merged
mariajgrimaldi merged 4 commits intoAug 1, 2023
Merged
Conversation
|
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
DmytroAlipov
force-pushed
the
fix-discussion-errors-palm
branch
from
June 14, 2023 18:59
d7d5721 to
a9f6670
Compare
Contributor
Author
|
@e0d Hi! already merged into the master ;) |
15 tasks
|
Hi @mariajgrimaldi! Is this something you can merge for us? |
Member
|
@mphilbrick211: yes! |
regisb
added a commit
to overhangio/tutor
that referenced
this pull request
Jul 31, 2023
This is a backport of a commit to the master branch: openedx/openedx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
regisb
added a commit
to overhangio/tutor
that referenced
this pull request
Jul 31, 2023
This is a backport of a commit to the master branch: openedx/openedx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
Contributor
|
This backport will be cherry-picked in Tutor: overhangio/tutor#881 |
regisb
added a commit
to overhangio/tutor
that referenced
this pull request
Jul 31, 2023
This is a backport of a commit to the master branch: openedx/openedx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
mariajgrimaldi
approved these changes
Aug 1, 2023
mariajgrimaldi
left a comment
mariajgrimaldi
left a comment
Member
There was a problem hiding this comment.
Thanks for the patience! I tested this on my palm environment, and it worked like a charm! Thank you so much 🚀
yusuf-musleh
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Aug 10, 2023
Discussion: - openedx/wg-build-test-release#276 Co-authored-by: Edward Zarecor <ezarecor@tcril.org>
moonesque
pushed a commit
to edSPIRIT/tutor
that referenced
this pull request
Nov 20, 2023
This is a backport of a commit to the master branch: openedx/openedx-platform#32464 In particular, it will fix many issues that appear when the demo course is imported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport from the master branch
Description
This is a bug fix that was taken from the discussion.
This issue is possible for the Demo course as well as other courses.
To reproduce this bug, you need the following conditions:
This fix eliminates the possibility of displaying the Discussion block if the environment variable ENABLE_DISCUSSION_SERVICE is set to False: