[BB-3622] Port the add course creation condition for organisation for koa.3 - #423
Merged
farhaanbukhsh merged 3 commits intoOct 4, 2021
Merged
Conversation
…6616) Current State (before this commit): Studio, as of today doesn't have a way to restrict a user to create a course in a particular organization. What Studio provides right now is a CourseCreator permission which gives an Admin the power to grant a user the permission to create a course. For example: If the Admin has given a user Spiderman the permission to create courses, Spiderman can now create courses in any organization i.e Marvel as well as DC. There is no way to restrict Spiderman from creating courses under DC. Purpose of this commit: The changes done here gives Admin the ability to restrict a user on an Organization level from creating courses via the Course Creators section of the Studio Django administration panel. For example: Now, the Admin can give the user Spiderman the privilege of creating courses only under Marvel organization. The moment Spiderman tries to create a course under some other organization(i.e DC), Studio will show an error message. This change is available to all Studio instances that enable the FEATURES['ENABLE_CREATOR_GROUP'] flag. Regardless of the flag, it will not affect any instances that choose not to use it. BB-3622
1 task
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
|
@farhaanbukhsh, I can't immediately understand why we're reverting #352 here. Could you explain? |
Member
Author
@0x29a We are not just reverting #352, it got upstreamed in a much cleaner way, this is just to port the clean fix from upstream to our branch. And in order to do that we need to revert those changes. We no longer need a feature flag for this fix and it gives users a better way to associate the course creator to an organization through the admin interface. |
0x29a
approved these changes
Oct 4, 2021
0x29a
left a comment
0x29a
left a comment
There was a problem hiding this comment.
👍
- I tested this: registered new user and checked that course access roles are being created / removed as described in the parent pull request.
- I read through the code.
- Includes documentation.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ths PR ports the functionality introduced in https://github.com/edx/edx-platform/pull/26616
JIRA tickets: BB-3622
Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.Dependencies: None
Screenshots: Upstream PR
Sandbox URL: TBD - sandbox is being provisioned.Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.
Testing instructions:
Upstream PR
Author notes and concerns:
None
Reviewers