[BB-3622] Restrict user create course (#319) - #328
Conversation
* Add course creation condition for organization The condition added to ensure that if the feature is enabled user will not be able to create the course outside of the organization in which they belong. Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
|
@farhaanbukhsh, thanks for creating this PR. Since the Koa upgrade is not going to happen any time soon and the preparation work has to be done before that, I'd like to wait till the upstream review is done before backporting this to Koa. What do you say? |
|
@farhaanbukhsh @lgp171188 your upstream PR https://github.com/edx/edx-platform/pull/26616 has merged -- do we still need this PR? If so, it should be rebased and made against Also, worth creating a PR to get this into lilac.master if it's needed for the next upgrade. |
|
@pomegranited I am planning to backport the fix for koa.3 and lilac.1, so I will be using this branch and PR to do the same. :) Thanks for the nudge. :) |
|
@pomegranited a lot of things changes so opening a clean PR was faster than rebase the current one :) so I am closing this PR in favor of #423 :) Hope that's okay. |
The condition added to ensure that if the feature is enabled
user will not be able to create the course outside of the organisation
in which they belong.
JIRA tickets: BB-3622
Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.Dependencies: None
Sandbox URL: TBD - sandbox is being provisioned.Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.Testing instructions:
make dev.shell.studioFEATURESdictionary addRESTRICT_NON_ORG_COURSE_CREATION: truestaffuseradminpage and in localhost:18010/admin/student/courseaccessrole/ create a new entry, add the user, give it instructor privilege, don't add theOrgyetAuthor notes and concerns:
Reviewers