[BB-4047][Backport] fix: fix typo that prevented video completion working as intended - #348
Merged
Agrendalath merged 1 commit intoApr 30, 2021
Conversation
Neither of these settings were being correctly set: * COMPLETION_BY_VIEWING_DELAY_MS * COMPLETION_VIDEO_COMPLETE_PERCENTAGE AA-743 (cherry picked from commit 5169d70)
janimo
approved these changes
Apr 30, 2021
janimo
left a comment
janimo
left a comment
There was a problem hiding this comment.
👍
- I tested this: (describe what you tested)
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the fix from edx/edx-platform#27230.
Testing instructions