This repository was archived by the owner on Aug 3, 2026. It is now read-only.
fix: revert Celery command change for services using Celery<5 - #194
Merged
Agrendalath merged 1 commit intoMay 13, 2022
Merged
Conversation
Agrendalath
marked this pull request as ready for review
May 13, 2022 08:40
gabor-boros
approved these changes
May 13, 2022
gabor-boros
left a comment
There was a problem hiding this comment.
@Agrendalath Nice! Could you please cherry-pick this to maple as well?
Member
Author
|
@gabor-boros, we don't have the Maple branch ready yet, so I've left a note on BB-6123. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186. Celery was upgraded only for the
edx-platform. Other repositories are still using Celery<5.This directly affects ecommerce-worker and breaks the deployment process when SANDBOX_ENABLE_ECOMMERCE: true is defined.
The
/edx/var/log/supervisor/ecomworker-stderr.logfile contains:The following services could also be affected:
However, I've noticed something odd in the
edx_django_serviceplaybook. While supervisor worker configs are created for these services, no task would enable them. There is only a task which creates and enables the config for the service's main process.FYI: @gabor-boros