Skip to content
This repository was archived by the owner on Aug 3, 2026. It is now read-only.

fix: revert Celery command change for services using Celery<5 - #194

Merged
Agrendalath merged 1 commit into
opencraft-release/lilac.2from
agrendalath/se-4860-fix_broken_celery_wokers
May 13, 2022
Merged

fix: revert Celery command change for services using Celery<5#194
Agrendalath merged 1 commit into
opencraft-release/lilac.2from
agrendalath/se-4860-fix_broken_celery_wokers

Conversation

@Agrendalath

@Agrendalath Agrendalath commented May 12, 2022

Copy link
Copy Markdown
Member

Fixes #186. Celery was upgraded only for the edx-platform. Other repositories are still using Celery<5.

This directly affects ecommerce-worker and breaks the deployment process when SANDBOX_ENABLE_ECOMMERCE: true is defined.

The /edx/var/log/supervisor/ecomworker-stderr.log file contains:

Error: 
Unable to load celery application.
Module 'ecommerce_worker' has no attribute 'celery'



The following services could also be affected:

However, I've noticed something odd in the edx_django_service playbook. While supervisor worker configs are created for these services, no task would enable them. There is only a task which creates and enables the config for the service's main process.

FYI: @gabor-boros

@Agrendalath Agrendalath self-assigned this May 12, 2022
@Agrendalath
Agrendalath marked this pull request as ready for review May 13, 2022 08:40

@gabor-boros gabor-boros left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agrendalath Nice! Could you please cherry-pick this to maple as well?

@Agrendalath
Agrendalath merged commit 36b3a1a into opencraft-release/lilac.2 May 13, 2022
@Agrendalath
Agrendalath deleted the agrendalath/se-4860-fix_broken_celery_wokers branch May 13, 2022 11:24
@Agrendalath

Copy link
Copy Markdown
Member Author

@gabor-boros, we don't have the Maple branch ready yet, so I've left a note on BB-6123.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants