This repository was archived by the owner on Aug 3, 2026. It is now read-only.
[SE-4860] cherry-pick configuration/pull/6586 - #186
Merged
gabor-boros merged 6 commits intoApr 27, 2022
Merged
Conversation
Other squashed commit messages: fix: celery 5.0+ does not support --app as a worker flag refactor: remove duplicated app declaration fix: --config flag is global since Celery 5.0+ fix: replace single-beat with an updated version fix: add missing comma fix: replace maxtasksperchild worker flag refactor: address PR review comments refactor: remove celery<5 adjustments fix: set single-beat autorestart Signed-off-by: Gabor Boros <gabor.brs@gmail.com> (cherry picked from commit d0550581cfd6309c61aaf751ea88a6f1c54c143c) Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Agrendalath
approved these changes
Mar 30, 2022
Agrendalath
left a comment
Agrendalath
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this: verified that grade reports work on the test instance
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository
…clean (cherry picked from commit 1f4ff35)
farhaanbukhsh
pushed a commit
that referenced
this pull request
Jun 16, 2022
* feat: make SINGLE_BEAT_IDENTIFIER configurable Other squashed commit messages: fix: celery 5.0+ does not support --app as a worker flag refactor: remove duplicated app declaration fix: --config flag is global since Celery 5.0+ fix: replace single-beat with an updated version fix: add missing comma fix: replace maxtasksperchild worker flag refactor: address PR review comments refactor: remove celery<5 adjustments fix: set single-beat autorestart Signed-off-by: Gabor Boros <gabor.brs@gmail.com> (cherry picked from commit d0550581cfd6309c61aaf751ea88a6f1c54c143c) Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * fix: bump setuptools Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * fix: reset setuptools Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * Update openedx_native.yml * revert custom extra requirements * fix: add safe directory config and use escalated privileges with git clean (cherry picked from commit 1f4ff35) Co-authored-by: nadeemshahzad <nshahzad@edx.org>
0x29a
pushed a commit
that referenced
this pull request
Jun 17, 2022
* feat: make SINGLE_BEAT_IDENTIFIER configurable Other squashed commit messages: fix: celery 5.0+ does not support --app as a worker flag refactor: remove duplicated app declaration fix: --config flag is global since Celery 5.0+ fix: replace single-beat with an updated version fix: add missing comma fix: replace maxtasksperchild worker flag refactor: address PR review comments refactor: remove celery<5 adjustments fix: set single-beat autorestart Signed-off-by: Gabor Boros <gabor.brs@gmail.com> (cherry picked from commit d0550581cfd6309c61aaf751ea88a6f1c54c143c) Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * fix: bump setuptools Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * fix: reset setuptools Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * Update openedx_native.yml * revert custom extra requirements * fix: add safe directory config and use escalated privileges with git clean (cherry picked from commit 1f4ff35) Co-authored-by: nadeemshahzad <nshahzad@edx.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of openedx-unsupported#6586
This PR allows setting separate users for single-beat and celery brokers, allows authentication, and setting the single-beat identifier for future fine-grained access control using Redis ACLs.
Also, we are replacing the source url of the package, hence the original code became outdated and
akachanov:masteris ahead of the original repo by fixing issues and removing incompatible code.Supporting information
Some months ago edX platform was not capable of doing periodic scheduling of celery tasks. Therefore we added celerybeat to the platform. The only issue with celerybeat is that it cannot run more than once. If multiple celerybeat schedulers are running at the same time, the same task can be scheduled multiple times resulting in unwanted behaviours. Here comes
single-beatinto picture that ensures (using redis) that no more than one celerybeat processes are running.Akachanov removed Tornadis that was published in 2018 for the last time and broke with the newest Celery. Using Akachanov's fork ensures that single-beat is still working with the newest Celery and he also seems to fixed some reconnect issues -- I assume hence the celerybeat process restarts, since I cannot see any errors and periodically scheduled tasks are processed as expected.