Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schema-strict for all fields #139

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Make schema-strict for all fields #139

merged 1 commit into from
Apr 24, 2020

Conversation

romifz
Copy link
Contributor

@romifz romifz commented Apr 23, 2020

Ref open-contracting/ocds-extensions#102

I left the string type conditions as they are, I hope that's OK.

@jpmckinney
Copy link
Member

Looks good!

Yes, I think the idea is that minLength becomes redundant if enum, format or pattern are present. A JSON Schema validator would report an extra message that is less useful to the user.

I'm re-running the tests as I don't see what the issue could be.

@jpmckinney jpmckinney merged commit ca808d9 into master Apr 24, 2020
@jpmckinney jpmckinney deleted the schema-strict-all-fields branch April 24, 2020 00:38
@jpmckinney
Copy link
Member

I've now run this against all non-core extensions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romifz @jpmckinney