META: Add validation properties to all fields

[jpmckinney]

See open-contracting/standard#859

This can be done by running ocdskit schema-strict on the schemas.

Note: OCDS Kit's schema-strict will add uniqueItems to the location extension's geometry field, which is not desirable.

[romifz]

Hey @jpmckinney, I'm not sure of the scope of this issue.

The title of open-contracting/standard#859 is "All strings, arrays, objects should have minLength, minItems, minProperties" and the first comment says:

If a field is optional, these validation properties are ignored, unless the field is present.

But in open-contracting-extensions/ocds_contract_signatories_extension#21 you say:

We typically don't set minItems on optional fields.

Is this issue about checking that all required fields have proper validation properties, then?

[jpmckinney]

Sorry, I was confusing our current practice with our desired practice :)

Your understanding is correct (from open-contracting/standard#859).

However, instead of making PRs against individual extensions, I think it's better to make a PR to change the schema-strict command in OCDS Kit, to make the changes programmatically. I can then run the updated command against all extensions at once, and commit the changes (I've done this a few times before for other issues).

For a first PR, we can keep the logic simple. There might be cases where we can be more restrictive, based on the specific logic of the field, but we need to be careful like in open-contracting-extensions/ocds_contract_signatories_extension#21, because a rule that works in a compiled release might not work in an individual release.

[romifz]

Thanks James, that makes sense. I'll check the schema-strict command.

[jpmckinney]

Done for non-core extensions. Leaving open for core extensions.