-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bids: Make awards.relatedBid an array #125
Bids: Make awards.relatedBid an array #125
Comments
@jpmckinney this seems like a straightforward change, i.e. deprecating |
Can you get a quick statistic from OCDS Downloads on how frequently relatedBid is used? |
It's used in all the digiwhist publications, plus:
Noting that there's no data available in OCDS Downloads for:
|
We don't expect Afghanistan or TenderBase to come back, and I think Positive Initiative and OpenOpps don't track bid information. @yolile Do you know about Paraguay? |
In Paraguay, we use the bids extension and therefore the |
@jpmckinney based on the above, what do you think we should do? |
I think we can go ahead with the proposed change to The contract related to the combined award will be singular, and we want the number of contracts in OCDS to match reality. On the other hand, awards are somewhat artificial constructs, so their number is less important. An option I considered is whether to represent the "combined" award as individual Award objects. However, this is not an option, since the Contract object has a singular |
Hmm, just remembered this discussion with @JachymHercher open-contracting/standard#790 However, the last comment provides alternatives, and it seems like a more narrow problem. At any rate, even if we make |
Sounds good! I'll prepare a PR. |
Hello, two clarifying questions here:
(This point is an alternative to the above, you can probably ignore it.)
Also, on the basis of this issue, I've created #182 (comment). |
The concrete implementation of eForms does indeed use identifiers prefixed with GLO- (Group of LOts), LOT- and PAR- (Part). https://docs.ted.europa.eu/eforms/0.6.0/schema/procedure-lot-part-information.html. All of these are represented by a Regarding eForms, there is no need or desire to match the modeling. There is only a desire to match the coverage of concepts. That said, how do the two options compare, for a data user? In eForms:
In OCDS:
Honestly, at some points, I wanted to give up figuring out how to do this in eForms. For (3), if a bidder submits multiple bids for the same lot, how would you know which was the winning bid if there is no |
I've never looked into the concrete implementation of eForms (regrettably or luckily - not sure) - it was done after I more or less left the field. Consequently, I won't argue with you on which modelling is better :).
In eForms:
In OCDS: An equivalent of 1) wouldn't work, because OCDS has Contracts linking to Awards and Awards relying on Suppliers, right? Then I guess we would need an equivalent to 2), which I guess currently doesn't exist, but would/should be part of I noticed only now that OCDS already has If https://extensions.open-contracting.org/en/extensions/awardCriteria/master/ accepted (I'll just drop here a random potential complication to watch out for, coming from eForms. Consider two scenarios (which can happen at the same time): We need to be able to distinguish these situations, so, for example, we can't just link award criteria to lots 1, 3 and 5 and assume it's enough - it might be ambiguous. However, I think (I'm not 100% well oriented in the award criteria extension, or rather its interaction with the lot extension) that currently in the extension we just give award criteria per one lot, not multiple lots, so this shouldn't be a problem.) |
FWIW, the annex to the regulation is straight-forward. The concrete implementation – not so much. The EU basically has 3 models now: ePO, annex, and eForms XML. The models correspond, but they are not identical. eForms XML simplifies some things (e.g. it removes some indicator fields, relying instead on the presence of scalar fields), and complicates others. I'm confused. You had said:
And now you clarified:
But BT-3202 is essentially the same as Award.relatedBids (well, it's more like Contract.relatedBids – but anyway, it's definitely not like bid.relatedLots). I don't see an issue between putting relatedBids on Award vs. Contract, but at any rate, that's a different issue than your first quote above. I've opened #183 about referencing Yes, https://extensions.open-contracting.org/en/extensions/awardCriteria/master/schema/ creates We could have instead had free-floating criteria, which then reference (or are referenced by) lots. However, our experience has been that implementers and users have a lot of trouble with highly referential data. In OCDS, only top-level concepts get referenced (parties, lots, bids, awards); unlike criteria, these can't be construed as being nested under another array. |
Contract Tender Identifier (BT-3202) is a repeatable field, but it is unrelated to groups of lots (for which a contract would link to a single tender which links to a single group which links to several lots). Instead, it is repeatable because eForms allow for several awards (for different lots) to result in a single contract. Was this the source of confusion? |
I am no closer to clarity :) This issue is closed. Could you please restate, as simply as possible, what your question or concern is? |
Restating (still along the lines of #125 (comment)):
|
An award needs to refer to the winning bid(s), whether in OCDS or otherwise. There's a question as to whether these references need to be repeatable. In the EU, the groups of lots must be stated beforehand, according to Art 36(3) of 2014/24/EU. In eForms, this is BG-330 ( Group Lot Award). In terms of the result, in eForms, BG-7 (Notice Result) contains BG-310 (Contract), which contains BT-3202 (Contract Tender Identifier). BT-3202 is repeatable. This is also true in eForms' concrete implementation, as described in #125 (comment), where Note that, in TED XML, the description of the groups of lots is free text (/OBJECT_CONTRACT/LOT_DIVISION/LOT_COMBINING_CONTRACT_RIGHT), and the contract refers to the lot (/AWARD_CONTRACT/LOT_NO), with no support for groups of lots and no reference to bids at all. Are you saying that BT-3202 should not have been repeatable?
|
No. In the eForms regulation, it is correctly repeatable for the reason stated at the end of #125 (comment). I've very slightly updated it, but I'm not sure I know how to explain it better in writing.
|
Aha, so in eForms, there would be a 1:1 relationship between award and bid ("tender") and lot/group, but this relationship is not explicit, because the notice result instead focuses on the contract (which can itself combine awards and lots/groups). This issue is becoming a bit of a all-consuming topic, so I'll continue after a line break. In eForms, a bid can only be for a single lot or a single (pre-defined) group of lots. However, the concrete implementation decomposes a bid into parts, each corresponding to a lot of group of lots: https://docs.ted.europa.eu/eforms/0.6.0/schema/competition-results.html#lotTenderSection At present, in OCDS, the bids extension has no such discussion. That said, its use of If we were to simplify OCDS' bids and lots model, we could remove If folks agree with that suggestion, please create a new issue, as it seems the least controversial change. We could similarly require that bids always be decomposed per lot. Whether we do that at top-level (e.g. hundreds of Bid objects for one offer of medicine products) or at a second-level (e.g. hundreds of BidPart objects within a Bid object) will depend on what questions we want to be easiest to answer. (I suspect users want to be able to count the number of submissions, not the number of bid parts, for example.) As before, if all we know is that a bid is for 3 lots, but no more lot-specific details, then each BidPart object would just contain an At this point, we'd have If we impose all these above constraints, we're left with many questions:
Right now, arrays make it so that we don't need to answer these questions, because all scenarios are supported. In order to limit the cardinality to 1, then we need to answer these questions. |
@jpmckinney shall I create the issue proposed in your previous comment (it sounds good to me) or do you want to wait for more input? |
@yolile @ColinMaudry What do you think? Do you have a sense of how many implementers it affects? |
I have never worked on an implementation that included bids, so my experience is close to Jachym's: the French/EU/eForm way of doing things. I think @jpmckinney implies in his last big comment (#125 (comment)) that we need
because otherwise, there is no way to know which part (lots or groups of lots) of the bid are successful. A tenderer bids on lot 1 and 3 (one bid, two parts), but they may only be awarded a contract for the part of their bid related to lot 1. But if a BidPart is evaluated as a whole, is a Bid with The way I see it, we have three main options, with their pros/cons:
|
Hmm I see that at least united_kingdom_wales, united_kingdom_fts, Netherlands, *_digiwhist, united_kingdom_scotland, moldova, italy_anac and Germany use Award.relatedLots
I think your proposal makes conceptual sense, as an award is made against a bid, not against a tender (and even in direct tenders I guess we could say the single tenderer made a bid)
And tenderers? |
In some cases the tenderers can make multiples bids, one for each lot or item that are being tender. And then, the procuring entity can make an award that includes differents items/lots that were bidded in differents bids.
For example, the EU has "The contracting authority reserves the right to award contracts combining the following lots or groups of lots".
Due that, OCDS should have a way to combine multiple bids on different lots into one award.
To make that possible the suggestion is that the
Award.relatedBid
field change toAward.relatedBids
and become an array instead of a string.cc @jpmckinney
The text was updated successfully, but these errors were encountered: