Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Award.relatedBid with Award.relatedBids #46

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Replace Award.relatedBid with Award.relatedBids #46

merged 3 commits into from
Feb 8, 2022

Conversation

duncandewhurst
Copy link
Member

Closes #125

@duncandewhurst
Copy link
Member Author

The checks are failing with the following error:

test_readme.py::test_example_backticks
README.md: "Award.relatedBid" term is not in schema

However, Award.relatedBid is in the schema, it's just deprecated.

@mrshll1001 mrshll1001 self-assigned this Feb 4, 2022
mrshll1001
mrshll1001 approved these changes Feb 4, 2022
View reviewed changes
Copy link

@mrshll1001 mrshll1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@jpmckinney
Copy link
Member

We need to mark the old field as deprecated, since the governance process applies to this extension.

@duncandewhurst
Copy link
Member Author

Ah looks like ocdskit indent unexpectedly removed the old property and deprecation note because I had accidentally duplicated `definitions/Award/properties. I've added it back in af83df6 and opened open-contracting/ocdskit#182 in case we want to change that behaviour.

jpmckinney
jpmckinney reviewed Feb 7, 2022
View reviewed changes
release-schema.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@duncandewhurst duncandewhurst merged commit 7e759a9 into master Feb 8, 2022
@duncandewhurst duncandewhurst deleted the 125-relatedBids branch February 8, 2022 02:05
@JachymHercher JachymHercher mentioned this pull request May 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrshll1001 mrshll1001 mrshll1001 approved these changes

@jpmckinney jpmckinney jpmckinney approved these changes

@odscrachel odscrachel Awaiting requested review from odscrachel

Assignees

@mrshll1001 mrshll1001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bids: Make awards.relatedBid an array
3 participants
@duncandewhurst @jpmckinney @mrshll1001