Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minItems property #21

Closed
wants to merge 1 commit into from
Closed

Add minItems property #21

wants to merge 1 commit into from

Conversation

romifz
Copy link
Contributor

@romifz romifz commented Apr 21, 2020

Ref open-contracting/ocds-extensions#102

Using "minItems": 2 since a contract should have at least two signatures.

@jpmckinney
Copy link
Member

We typically don't set minItems on optional fields. Also, since the field uses identifier merge, it's possible to add one signatory in a later release.

@romifz romifz mentioned this pull request Apr 21, 2020
Open
@romifz
Copy link
Contributor Author

romifz commented Apr 21, 2020

We typically don't set minItems on optional fields. Also, since the field uses identifier merge, it's possible to add one signatory in a later release.

I see, I added a question for you in open-contracting/ocds-extensions#102.

@jpmckinney
Copy link
Member

Closing for now. See linked issue.

@jpmckinney jpmckinney closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romifz @jpmckinney