Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(client): Continue derivation on execution failure#545

Merged
clabby merged 1 commit intomainfrom
cl/fix-executor-loop
Sep 21, 2024
Merged

fix(client): Continue derivation on execution failure#545
clabby merged 1 commit intomainfrom
cl/fix-executor-loop

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Sep 21, 2024

Overview

Applies a fix to the client program's derivation driver, where it threw if a block execution failed. This case can be hit in the event that a malicious batcher posts a bad batch on L1 mainnet.

This change makes us pass the new action tests.

Copy link
Contributor Author

clabby commented Sep 21, 2024

@clabby clabby added K-fix Kind: fix A-binaries Area: binaries labels Sep 21, 2024
@clabby clabby self-assigned this Sep 21, 2024
@clabby clabby force-pushed the cl/executor-error-conversion branch from 193ca40 to 1ae2bb5 Compare September 21, 2024 21:29
@clabby clabby force-pushed the cl/fix-executor-loop branch from 5bcbf9e to fb81a07 Compare September 21, 2024 21:29
@clabby clabby force-pushed the cl/executor-error-conversion branch from 1ae2bb5 to 43c896e Compare September 21, 2024 22:47
@clabby clabby force-pushed the cl/fix-executor-loop branch from fb81a07 to 2bc8b06 Compare September 21, 2024 22:48
@codecov
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.0%. Comparing base (1b841b3) to head (d95b5ae).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/fix-executor-loop branch from 2bc8b06 to 0e252a1 Compare September 21, 2024 22:53
@clabby clabby changed the base branch from cl/executor-error-conversion to main September 21, 2024 22:53
@clabby clabby force-pushed the cl/fix-executor-loop branch from 0e252a1 to d95b5ae Compare September 21, 2024 22:54
@clabby clabby added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit d61fd23 Sep 21, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-binaries Area: binaries K-fix Kind: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants