Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(executor): Migrate to thiserror#544

Merged
clabby merged 2 commits intomainfrom
cl/executor-error-conversion
Sep 21, 2024
Merged

feat(executor): Migrate to thiserror#544
clabby merged 2 commits intomainfrom
cl/executor-error-conversion

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Sep 21, 2024

Overview

Migrates kona-executor to thiserror

Copy link
Contributor Author

clabby commented Sep 21, 2024

@codecov
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 88.17204% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (abbbc88) to head (43c896e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/lib.rs 88.7% 8 Missing ⚠️
crates/executor/src/eip4788.rs 84.6% 2 Missing ⚠️
crates/executor/src/errors.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby added K-feature Kind: feature A-protocol Area: protocol crates labels Sep 21, 2024
@clabby clabby self-assigned this Sep 21, 2024
@clabby clabby force-pushed the cl/preimage-error-conversion branch from 2c44dbd to 6b32a3d Compare September 21, 2024 21:29
@clabby clabby force-pushed the cl/executor-error-conversion branch from 193ca40 to 1ae2bb5 Compare September 21, 2024 21:29
@clabby clabby force-pushed the cl/executor-error-conversion branch from 1ae2bb5 to 43c896e Compare September 21, 2024 22:47
@clabby clabby changed the base branch from cl/preimage-error-conversion to main September 21, 2024 22:47
@clabby clabby enabled auto-merge September 21, 2024 22:49
@clabby clabby added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit 1b841b3 Sep 21, 2024
This was referenced Sep 21, 2024
@github-actions github-actions bot mentioned this pull request Oct 13, 2024
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
* feat(executor): Migrate to `thiserror`

* lint
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
* feat(executor): Migrate to `thiserror`

* lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-protocol Area: protocol crates K-feature Kind: feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants