Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Revert "chore(ci/cache): cache reth deps"#3040

Merged
theochap merged 1 commit intomainfrom
revert-3039-theo/cache-reth
Nov 14, 2025
Merged

Revert "chore(ci/cache): cache reth deps"#3040
theochap merged 1 commit intomainfrom
revert-3039-theo/cache-reth

Conversation

@theochap
Copy link
Member

Description

Reverts #3039

It seems that this doesn't solve the caching issues

Copilot AI review requested due to automatic review settings November 14, 2025 17:28
@theochap theochap merged commit 75a5059 into main Nov 14, 2025
38 of 39 checks passed
@theochap theochap deleted the revert-3039-theo/cache-reth branch November 14, 2025 17:28
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.3%. Comparing base (9696f39) to head (d8b5d68).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous caching optimization attempt (PR #3039) that used cache-directories to cache reth dependencies, returning to the workspaces configuration for the Swatinem/rust-cache action.

  • Reverts from cache-directories to workspaces parameter for rust-cache@v2
  • Restores caching for both the main workspace (.) and the reth submodule workspace (tests/reth)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
## Description

Reverts op-rs/kona#3039

It seems that this doesn't solve the caching issues
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
## Description

Reverts op-rs/kona#3039

It seems that this doesn't solve the caching issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants