Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix CI caching for reth dependencies by modifying the Swatinem/rust-cache configuration in the setup action. The change replaces the workspaces parameter with cache-directories and removes caching for the main project workspace.
Key Changes
- Replaced
workspacesparameter withcache-directories - Removed main workspace caching (
. -> target) - Changed reth caching from
tests/reth -> tests/reth/targettotests/reth/target
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cache-directories: | | ||
| tests/reth/target |
There was a problem hiding this comment.
The cache-directories parameter is intended for caching additional non-Rust directories. For Rust workspace caching, the correct parameter is workspaces. This change removes caching for the main project workspace (. -> target) and incorrectly uses cache-directories instead of workspaces for the reth submodule. The correct configuration should be:\nyaml\nworkspaces: |\n . -> target\n tests/reth -> tests/reth/target\n\nThis ensures both the main project and the reth submodule target directories are properly cached by Swatinem/rust-cache@v2.
| cache-directories: | | |
| tests/reth/target | |
| workspaces: | | |
| . -> target | |
| tests/reth -> tests/reth/target |
## Description Reverts #3039 It seems that this doesn't solve the caching issues
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. |
## Description Fix CI caching for reth dependencies
## Description Reverts op-rs/kona#3039 It seems that this doesn't solve the caching issues
## Description Fix CI caching for reth dependencies
## Description Reverts op-rs/kona#3039 It seems that this doesn't solve the caching issues
Description
Fix CI caching for reth dependencies