Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(ci/cache): cache reth deps#3039

Merged
theochap merged 1 commit intomainfrom
theo/cache-reth
Nov 14, 2025
Merged

chore(ci/cache): cache reth deps#3039
theochap merged 1 commit intomainfrom
theo/cache-reth

Conversation

@theochap
Copy link
Member

Description

Fix CI caching for reth dependencies

Copilot AI review requested due to automatic review settings November 14, 2025 17:19
@theochap theochap merged commit 9696f39 into main Nov 14, 2025
40 of 41 checks passed
@theochap theochap deleted the theo/cache-reth branch November 14, 2025 17:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to fix CI caching for reth dependencies by modifying the Swatinem/rust-cache configuration in the setup action. The change replaces the workspaces parameter with cache-directories and removes caching for the main project workspace.

Key Changes

  • Replaced workspaces parameter with cache-directories
  • Removed main workspace caching (. -> target)
  • Changed reth caching from tests/reth -> tests/reth/target to tests/reth/target

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +57 to +58
cache-directories: |
tests/reth/target
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache-directories parameter is intended for caching additional non-Rust directories. For Rust workspace caching, the correct parameter is workspaces. This change removes caching for the main project workspace (. -> target) and incorrectly uses cache-directories instead of workspaces for the reth submodule. The correct configuration should be:\nyaml\nworkspaces: |\n . -> target\n tests/reth -> tests/reth/target\n\nThis ensures both the main project and the reth submodule target directories are properly cached by Swatinem/rust-cache@v2.

Suggested change
cache-directories: |
tests/reth/target
workspaces: |
. -> target
tests/reth -> tests/reth/target

Copilot uses AI. Check for mistakes.
theochap added a commit that referenced this pull request Nov 14, 2025
theochap added a commit that referenced this pull request Nov 14, 2025
## Description

Reverts #3039

It seems that this doesn't solve the caching issues
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.3%. Comparing base (be9d673) to head (dc5abab).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
## Description

Fix CI caching for reth dependencies
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
## Description

Reverts op-rs/kona#3039

It seems that this doesn't solve the caching issues
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
## Description

Fix CI caching for reth dependencies
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
## Description

Reverts op-rs/kona#3039

It seems that this doesn't solve the caching issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants