chore(node/deps): update rocksdb version

[theochap]

Description

Per title, should allow to fix #2437

[Copilot]

Pull Request Overview

Updates the RocksDB dependency from version 0.23.0 to 0.24.0 to address issue #2437.

• Updates RocksDB version in workspace dependencies

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[claude]

Claude finished @theochap's task —— View job

---

PR Review: RocksDB Version Update

Reviewing the RocksDB dependency update from 0.23.0 to 0.24.0.

Todo List:

• Read changed files to understand the update
• Analyze RocksDB version compatibility
• Check for potential breaking changes
• Assess impact on codebase
• Provide comprehensive review feedback

---

Code Review Feedback

Summary

This PR updates the RocksDB dependency from version 0.23.0 to 0.24.0 across the workspace. The change affects both Cargo.toml:261 and the corresponding Cargo.lock file.

Code Quality & Best Practices ✅

• Clean dependency update: The change is properly scoped to workspace dependencies
• Consistent versioning: Uses semantic versioning appropriately
• Proper feature flags: Maintains default-features = false which is good for dependency control

RocksDB Usage Analysis

The codebase uses RocksDB in a limited scope:

• Primary usage: bin/host/src/kv/disk.rs - DiskKeyValueStore implementation
• Usage patterns: Basic key-value operations (get, put), compression (Snappy), iteration
• Feature dependencies: Uses "snappy" and "bindgen-runtime" features from the host binary

Potential Issues & Compatibility 🟡

API Compatibility

Based on the usage patterns in bin/host/src/kv/disk.rs:7-56, the code uses:

• rocksdb::DB
• rocksdb::Options
• rocksdb::DBCompressionType::Snappy
• rocksdb::IteratorMode::Start

Recommendation: These are stable APIs that should remain compatible across 0.23.x to 0.24.x, but verification through testing is recommended.

Breaking Changes Potential

• RocksDB 0.24.0 may include performance improvements and bug fixes
• Minor version updates can introduce subtle behavioral changes
• The codebase's simple usage pattern reduces risk

Performance Considerations ✅

• The update likely includes performance improvements from the RocksDB C++ library
• No performance regressions expected from the current usage patterns
• Compression and iteration performance may improve

Security Concerns ✅

• Dependency updates generally improve security posture
• RocksDB 0.24.0 likely includes security patches from upstream
• No security risks introduced by this change

Test Coverage ⚠️

Current testing:

• Property-based tests exist in bin/host/src/kv/disk.rs:82-100
• Tests conversion between DiskKeyValueStore and MemoryKeyValueStore

Recommendations:

1. Run existing tests: Ensure the property tests still pass with the new version
2. Integration testing: Verify the host binary functions correctly with real data
3. Performance benchmarks: Consider running performance tests if available

Missing Considerations

• CHANGELOG entry: Should document this dependency update
• Issue reference: PR references issue chore(deps): update rocksdb dep to fix build #2437 but the specific problem isn't detailed in the PR description

---

Overall Assessment

Status: ✅ APPROVE with recommendations

This is a well-structured dependency update that follows good practices. The RocksDB usage in the codebase is straightforward and should be compatible with the version bump.

Required Actions:

1. Run the test suite to ensure compatibility
2. Verify the host binary works with existing databases

Recommended Actions:

1. Add more detail to the PR description about what issue chore(deps): update rocksdb dep to fix build #2437 describes
2. Consider adding a CHANGELOG entry for this dependency update
3. Run performance tests if available to validate no regressions

The change is low-risk given the simple usage patterns and the fact that this is a minor version update to a mature library.

---

[claude]

Claude finished @theochap's task —— View job

---

PR Review: RocksDB Version Update

Reviewing the RocksDB dependency update from 0.23.0 to 0.24.0.

Todo List:

• Read changed files to understand the update
• Analyze RocksDB usage in the codebase
• Check for potential breaking changes
• Assess security and performance implications
• Evaluate test coverage needs
• Provide comprehensive review feedback

---

Code Review Feedback

Summary

This PR updates the RocksDB dependency from version 0.23.0 to 0.24.0 across the workspace. The change affects both Cargo.toml:261 and the corresponding Cargo.lock file.

Code Quality & Best Practices ✅

• Clean dependency update: The change is properly scoped to workspace dependencies
• Consistent versioning: Uses semantic versioning appropriately
• Proper feature flags: Maintains default-features = false which is good for dependency control

RocksDB Usage Analysis

The codebase uses RocksDB in a limited scope:

• Primary usage: bin/host/src/kv/disk.rs:7-56 - DiskKeyValueStore implementation
• Usage patterns: Basic key-value operations (get, put), compression (Snappy), iteration
• Feature dependencies: Uses "snappy" and "bindgen-runtime" features from the host binary

Potential Issues & Compatibility 🟡

API Compatibility
Based on the usage patterns in bin/host/src/kv/disk.rs:7-56, the code uses:

• rocksdb::DB
• rocksdb::Options
• rocksdb::DBCompressionType::Snappy
• rocksdb::IteratorMode::Start

Recommendation: These are stable APIs that should remain compatible across 0.23.x to 0.24.x, but verification through testing is recommended.

Breaking Changes Potential

• RocksDB 0.24.0 may include performance improvements and bug fixes
• Minor version updates can introduce subtle behavioral changes
• The codebase's simple usage pattern reduces risk

Performance Considerations ✅

• The update likely includes performance improvements from the RocksDB C++ library
• No performance regressions expected from the current usage patterns
• Compression and iteration performance may improve

Security Concerns ✅

• Dependency updates generally improve security posture
• RocksDB 0.24.0 likely includes security patches from upstream
• No security risks introduced by this change

Test Coverage ⚠️

Current testing:

• Property-based tests exist in bin/host/src/kv/disk.rs:82-100
• Tests conversion between DiskKeyValueStore and MemoryKeyValueStore

Recommendations:

1. Run existing tests: Ensure the property tests still pass with the new version
2. Integration testing: Verify the host binary functions correctly with real data
3. Performance benchmarks: Consider running performance tests if available

Missing Considerations

• CHANGELOG entry: Should document this dependency update
• Issue reference: PR references issue chore(deps): update rocksdb dep to fix build #2437 but the specific problem isn't detailed in the PR description

---

Overall Assessment

Status: ✅ APPROVE with recommendations

This is a well-structured dependency update that follows good practices. The RocksDB usage in the codebase is straightforward and should be compatible with the version bump.

Required Actions:

1. Run the test suite to ensure compatibility: just t or just tests
2. Verify the host binary works with existing databases

Recommended Actions:

1. Add more detail to the PR description about what issue chore(deps): update rocksdb dep to fix build #2437 describes
2. Consider adding a CHANGELOG entry for this dependency update
3. Run performance tests if available to validate no regressions

The change is low-risk given the simple usage patterns and the fact that this is a minor version update to a mature library.

---

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.9%. Comparing base (8323114) to head (e283d86).
⚠️ Report is 2 commits behind head on main.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.