Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(deps): update rocksdb dep to fix build#2437

Closed
protolambda wants to merge 1 commit intoop-rs:mainfrom
protolambda:fix-rocksdb-build
Closed

chore(deps): update rocksdb dep to fix build#2437
protolambda wants to merge 1 commit intoop-rs:mainfrom
protolambda:fix-rocksdb-build

Conversation

@protolambda
Copy link

@protolambda protolambda commented Jul 17, 2025

The kona repo failed to build due to a rocksdb C issue on my system.

This PR updates the dep, to support cstdint / GCC 15 / newer C toolchain, by including the rocksdb build fix (git rev, unfortunately no newer tagged releases to update to): rust-rocksdb/rust-rocksdb#1007

For anyone else running into toolchain issues, as work-around, building also works like this, without the dep fix:

export CXXFLAGS="$CXXFLAGS -include cstdint"
cargo b

Documenting it here for anyone else running into it...

To support cstdint / GCC 15 / newer C toolchain, include rocksdb build fix:
rust-rocksdb/rust-rocksdb#1007
Copilot AI review requested due to automatic review settings July 17, 2025 13:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the RocksDB dependency to a specific Git revision to include a build fix for newer C toolchains (cstdint/GCC 15).

  • Pin rust-rocksdb to a Git rev that contains the upstream C build fix.
  • Remove the crates.io version constraint in favor of the Git-based dependency.
Comments suppressed due to low confidence (2)

Cargo.toml:255

  • [nitpick] Add a comment above this dependency explaining that it's pinned to a Git rev (rust-rocksdb#1007) to include a C build fix for newer toolchains, so future maintainers understand the rationale.
rocksdb = { git = "https://github.com/rust-rocksdb/rust-rocksdb", rev = "7da6d11e669e1467d919764e446b82edeebb00c0", default-features = false }

Cargo.toml:255

  • Ensure the Cargo.lock file is updated and committed alongside this change to lock in the new Git-based rocksdb revision for reproducible builds and consistent CI.
rocksdb = { git = "https://github.com/rust-rocksdb/rust-rocksdb", rev = "7da6d11e669e1467d919764e446b82edeebb00c0", default-features = false }

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (1707d23) to head (80d621b).
⚠️ Report is 263 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby
Copy link
Contributor

clabby commented Jul 17, 2025

Thanks proto!

Unless urgent to support gcc15, would prefer to wait until they've released the update on crates.io. If we merge this, we'll no longer be able to release our crates that depend on rocksdb due to the git-sourced dependency.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@emhane emhane added M-blocked meta: blocked and removed M-stale labels Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@theochap
Copy link
Member

theochap commented Sep 9, 2025

#2839

@theochap theochap closed this Sep 9, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2025
## Description

Per title, should allow to fix #2437
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

M-blocked meta: blocked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants