chore(deps): update rocksdb dep to fix build#2437
chore(deps): update rocksdb dep to fix build#2437protolambda wants to merge 1 commit intoop-rs:mainfrom
Conversation
To support cstdint / GCC 15 / newer C toolchain, include rocksdb build fix: rust-rocksdb/rust-rocksdb#1007
There was a problem hiding this comment.
Pull Request Overview
This PR updates the RocksDB dependency to a specific Git revision to include a build fix for newer C toolchains (cstdint/GCC 15).
- Pin
rust-rocksdbto a Git rev that contains the upstream C build fix. - Remove the crates.io version constraint in favor of the Git-based dependency.
Comments suppressed due to low confidence (2)
Cargo.toml:255
- [nitpick] Add a comment above this dependency explaining that it's pinned to a Git rev (rust-rocksdb#1007) to include a C build fix for newer toolchains, so future maintainers understand the rationale.
rocksdb = { git = "https://github.com/rust-rocksdb/rust-rocksdb", rev = "7da6d11e669e1467d919764e446b82edeebb00c0", default-features = false }
Cargo.toml:255
- Ensure the Cargo.lock file is updated and committed alongside this change to lock in the new Git-based rocksdb revision for reproducible builds and consistent CI.
rocksdb = { git = "https://github.com/rust-rocksdb/rust-rocksdb", rev = "7da6d11e669e1467d919764e446b82edeebb00c0", default-features = false }
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. |
|
Thanks proto! Unless urgent to support gcc15, would prefer to wait until they've released the update on |
|
This pull request has been automatically marked as stale because it has been inactive for 3 weeks. |
|
This pull request has been automatically marked as stale because it has been inactive for 3 weeks. |
## Description Per title, should allow to fix #2437
## Description Per title, should allow to fix op-rs/kona#2437
The kona repo failed to build due to a rocksdb C issue on my system.
This PR updates the dep, to support cstdint / GCC 15 / newer C toolchain, by including the rocksdb build fix (git rev, unfortunately no newer tagged releases to update to): rust-rocksdb/rust-rocksdb#1007
For anyone else running into toolchain issues, as work-around, building also works like this, without the dep fix:
Documenting it here for anyone else running into it...