Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(supervisor): clean up typos, naming, and formatting in core modules #2720

Merged
emhane merged 4 commits into from
Aug 18, 2025
Merged

fix(supervisor): clean up typos, naming, and formatting in core modules #2720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d87aaa
add missing whitespace
Bashmunta Aug 17, 2025
a855c93
misleading comment
Bashmunta Aug 17, 2025
7d3a325
put point instead of comma
Bashmunta Aug 17, 2025
c5c95d3
add two missing whitespaces
Bashmunta Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/supervisor/core/src/reorg/task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ mod tests {
impl LogStorageReader for Db {
fn get_block(&self, block_number: u64) -> Result<BlockInfo, StorageError>;
fn get_latest_block(&self) -> Result<BlockInfo, StorageError>;
fn get_log(&self,block_number: u64,log_index: u32) -> Result<Log, StorageError>;
fn get_log(&self, block_number: u64,log_index: u32) -> Result<Log, StorageError>;
fn get_logs(&self, block_number: u64) -> Result<Vec<Log>, StorageError>;
}

Expand Down
2 changes: 1 addition & 1 deletion crates/supervisor/core/src/safety_checker/promoter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ impl SafetyPromoter for CrossUnsafePromoter {
}
}

/// CrossUnsafePromoter implements [`SafetyPromoter`] for [`SafetyLevel::CrossSafe`]
/// CrossSafePromoter implements [`SafetyPromoter`] for [`SafetyLevel::CrossSafe`]
Copy link
Copy Markdown
Contributor

@emhane emhane Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why it makes sense to doc link redundantly - the lint will catch if type names change which avoids doc inconsistency with code @varun-doshi @itschaindev @sadiq1971

#[derive(Debug)]
pub struct CrossSafePromoter;

Expand Down
2 changes: 1 addition & 1 deletion crates/supervisor/core/src/syncnode/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use kona_supervisor_storage::StorageError;
use thiserror::Error;

/// Represents various errors that can occur during node management,
/// Represents various errors that can occur during node management.
#[derive(Debug, Error, PartialEq, Eq)]
pub enum ManagedNodeError {
/// Represents an error that occurred while starting the managed node.
Expand Down
2 changes: 1 addition & 1 deletion crates/supervisor/core/src/syncnode/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ mod tests {
impl LogStorageReader for Db {
fn get_block(&self, block_number: u64) -> Result<BlockInfo, StorageError>;
fn get_latest_block(&self) -> Result<BlockInfo, StorageError>;
fn get_log(&self,block_number: u64,log_index: u32) -> Result<Log, StorageError>;
fn get_log(&self, block_number: u64, log_index: u32) -> Result<Log, StorageError>;
fn get_logs(&self, block_number: u64) -> Result<Vec<Log>, StorageError>;
}

Expand Down
Loading