This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix(supervisor): clean up typos, naming, and formatting in core modules#2720
Merged
emhane merged 4 commits intoop-rs:mainfrom Aug 18, 2025
Merged
fix(supervisor): clean up typos, naming, and formatting in core modules#2720emhane merged 4 commits intoop-rs:mainfrom
emhane merged 4 commits intoop-rs:mainfrom
Conversation
Bashmunta
requested review from
clabby,
dhyaniarun1993,
emhane,
itschaindev,
refcell,
sadiq1971 and
theochap
as code owners
emhane
reviewed
Aug 18, 2025
| } | ||
|
|
||
| /// CrossUnsafePromoter implements [`SafetyPromoter`] for [`SafetyLevel::CrossSafe`] | ||
| /// CrossSafePromoter implements [`SafetyPromoter`] for [`SafetyLevel::CrossSafe`] |
Contributor
There was a problem hiding this comment.
this is why it makes sense to doc link redundantly - the lint will catch if type names change which avoids doc inconsistency with code @varun-doshi @itschaindev @sadiq1971
refcell
approved these changes
Aug 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…es (op-rs/kona#2720) - Fixed spacing in function signatures (`get_log`) - Corrected doc comment typo: `CrossUnsafePromoter` → `CrossSafePromoter` - Fixed grammar/punctuation in `ManagedNodeError` docs
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…es (op-rs/kona#2720) - Fixed spacing in function signatures (`get_log`) - Corrected doc comment typo: `CrossUnsafePromoter` → `CrossSafePromoter` - Fixed grammar/punctuation in `ManagedNodeError` docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_log)CrossUnsafePromoter→CrossSafePromoterManagedNodeErrordocs