Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(client): Derivation integration#257

Merged
clabby merged 2 commits intomainfrom
cl/client-derivation
Jun 16, 2024
Merged

feat(client): Derivation integration#257
clabby merged 2 commits intomainfrom
cl/client-derivation

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Jun 16, 2024

Overview

Adds the DerivationDriver to the client program, bringing the first draft of the client program.

@clabby clabby self-assigned this Jun 16, 2024
@clabby clabby added K-feature Kind: feature A-binaries Area: binaries labels Jun 16, 2024
This was referenced Jun 16, 2024
Merged
Merged
Merged
Merged
@clabby Graphite App
Copy link
Contributor Author

clabby commented Jun 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby force-pushed the cl/client-derivation branch from 38c83bc to 94e3b0a Compare June 16, 2024 07:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.50000% with 186 lines in your changes missing coverage. Please review.

Project coverage is 70.3%. Comparing base (d1a3f08) to head (b13c48f).

Files Patch % Lines
bin/programs/client/src/l1/driver.rs 0.0% 76 Missing ⚠️
bin/programs/client/src/main.rs 0.0% 31 Missing ⚠️
bin/programs/client/src/l2/executor/mod.rs 22.8% 27 Missing ⚠️
bin/host/src/fetcher/mod.rs 0.0% 19 Missing ⚠️
bin/programs/client/src/l2/chain_provider.rs 0.0% 10 Missing ⚠️
crates/preimage/src/oracle.rs 58.8% 7 Missing ⚠️
bin/host/src/server.rs 0.0% 6 Missing ⚠️
bin/host/src/util.rs 0.0% 3 Missing ⚠️
bin/programs/client/src/hint.rs 0.0% 2 Missing ⚠️
crates/mpt/src/db/mod.rs 50.0% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as draft June 16, 2024 07:10
@clabby clabby force-pushed the cl/client-derivation branch 2 times, most recently from 281784d to 517634c Compare June 16, 2024 08:38
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 16, 2024
@clabby clabby mentioned this pull request Jun 16, 2024
Merged
@clabby clabby marked this pull request as ready for review June 16, 2024 09:20
@clabby clabby force-pushed the cl/host-sync-fixes branch from 2dab14e to 87e28c3 Compare June 16, 2024 17:55
@clabby clabby force-pushed the cl/client-derivation branch from 517634c to ca1024b Compare June 16, 2024 17:55
refcell
refcell reviewed Jun 16, 2024
View reviewed changes
refcell
refcell reviewed Jun 16, 2024
View reviewed changes
@refcell
Copy link
Contributor

refcell commented Jun 16, 2024

Approved with a few drive-by comments :)

@clabby clabby force-pushed the cl/host-sync-fixes branch from 87e28c3 to 1acce4d Compare June 16, 2024 20:16
@clabby clabby force-pushed the cl/client-derivation branch from ca1024b to 4668b31 Compare June 16, 2024 20:16
@clabby clabby force-pushed the cl/host-sync-fixes branch from 1acce4d to 03d3283 Compare June 16, 2024 20:51
@clabby clabby force-pushed the cl/client-derivation branch from 4668b31 to d328e14 Compare June 16, 2024 20:51
@clabby
feat(client): Derivation integration
8e07805 
Adds the `DerivationDriver` to the client program.
@clabby clabby force-pushed the cl/client-derivation branch from d328e14 to 8e07805 Compare June 16, 2024 21:36
@clabby clabby changed the base branch from cl/host-sync-fixes to main June 16, 2024 21:36
@clabby clabby enabled auto-merge June 16, 2024 21:37
@clabby clabby disabled auto-merge June 16, 2024 21:37
@clabby clabby enabled auto-merge June 16, 2024 21:42
@clabby clabby added this pull request to the merge queue Jun 16, 2024
Merged via the queue into main with commit 49a9d9c Jun 16, 2024
This was referenced Jun 16, 2024
Closed
Closed
Closed
Merged
@clabby clabby deleted the cl/client-derivation branch July 2, 2024 03:40
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@clabby
feat(client): Derivation integration (op-rs/kona#257)
a4afe23 
* feat(client): Derivation integration

Adds the `DerivationDriver` to the client program.

* andreas review
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@clabby
feat(client): Derivation integration (op-rs/kona#257)
ada1829 
* feat(client): Derivation integration

Adds the `DerivationDriver` to the client program.

* andreas review
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@refcell refcell refcell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@clabby clabby

Labels

A-binaries Area: binaries K-feature Kind: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clabby @codecov-commenter @refcell