Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(client): Add RollupConfig to BootInfo#251

Merged
refcell merged 1 commit intomainfrom
cl/rollup-cfg-boot
Jun 16, 2024
Merged

feat(client): Add RollupConfig to BootInfo#251
refcell merged 1 commit intomainfrom
cl/rollup-cfg-boot

Conversation

@clabby
Copy link
Copy Markdown
Contributor

@clabby clabby commented Jun 15, 2024

Overview

Adds a function in the BootInfo module that pulls in the rollup config based on the passed L2 chain ID.

@clabby
feat(client): Add RollupConfig to BootInfo
b355654 
## Overview

Adds a function in the `BootInfo` module that pulls in the rollup config
based on the passed L2 chain ID.
@clabby clabby self-assigned this Jun 15, 2024
@clabby Graphite App
Copy link
Copy Markdown
Contributor Author

clabby commented Jun 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request Jun 15, 2024
Merged
@clabby clabby added K-feature Kind: feature A-binaries Area: binaries labels Jun 15, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.3%. Comparing base (2b667ea) to head (b355654).

Files Patch % Lines
bin/programs/client/src/boot.rs 0.0% 7 Missing ⚠️
bin/host/src/kv/local.rs 0.0% 2 Missing ⚠️
bin/host/src/cli/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refcell
refcell reviewed Jun 15, 2024
View reviewed changes
refcell
refcell reviewed Jun 15, 2024
View reviewed changes
refcell
refcell reviewed Jun 15, 2024
View reviewed changes
refcell
refcell reviewed Jun 15, 2024
View reviewed changes
refcell
refcell reviewed Jun 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

This was referenced Jun 15, 2024
Merged
Merged
Merged
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 16, 2024
@clabby clabby linked an issue Jun 16, 2024 that may be closed by this pull request
feat(client): RollupConfig + ChainConfig in BootInfo #223
Closed
@clabby clabby mentioned this pull request Jun 16, 2024
Merged
@refcell refcell added this pull request to the merge queue Jun 16, 2024
Merged via the queue into main with commit 20ffe60 Jun 16, 2024
This was referenced Jun 16, 2024
Closed
Closed
Closed
@clabby clabby deleted the cl/rollup-cfg-boot branch July 2, 2024 03:36
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@clabby
feat(client): Add RollupConfig to BootInfo (op-rs/kona#251)
9ecea1f 
## Overview

Adds a function in the `BootInfo` module that pulls in the rollup config
based on the passed L2 chain ID.
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@clabby
feat(client): Add RollupConfig to BootInfo (op-rs/kona#251)
10c3595 
## Overview

Adds a function in the `BootInfo` module that pulls in the rollup config
based on the passed L2 chain ID.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@refcell refcell refcell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@clabby clabby

Labels

A-binaries Area: binaries K-feature Kind: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(client): RollupConfig + ChainConfig in BootInfo

3 participants

@clabby @codecov-commenter @refcell