Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(node/service): L1OriginSelector advancement #2404

Merged
clabby merged 1 commit into from
Jul 15, 2025
Merged

feat(node/service): L1OriginSelector advancement #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions crates/node/service/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ http-body-util.workspace = true
# metrics
metrics = { workspace = true, optional = true }

[dev-dependencies]
rstest.workspace = true

[features]
default = []
metrics = [
Expand Down
4 changes: 2 additions & 2 deletions crates/node/service/src/actors/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ pub use network::{

mod sequencer;
pub use sequencer::{
AttributesBuilderConfig, L1OriginSelector, L1OriginSelectorError, SequencerActor,
SequencerActorError, SequencerBuilder, SequencerContext, SequencerInboundData,
AttributesBuilderConfig, L1OriginSelector, L1OriginSelectorError, L1OriginSelectorProvider,
SequencerActor, SequencerActorError, SequencerBuilder, SequencerContext, SequencerInboundData,
};
14 changes: 12 additions & 2 deletions crates/node/service/src/actors/sequencer/actor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ struct SequencerActorState<AB: AttributesBuilder> {
/// The [`AttributesBuilder`].
pub builder: AB,
/// The [`L1OriginSelector`].
pub origin_selector: L1OriginSelector,
pub origin_selector: L1OriginSelector<RootProvider>,
}

/// A trait for building [`AttributesBuilder`]s.
Expand Down Expand Up @@ -161,7 +161,17 @@ impl<AB: AttributesBuilder> SequencerActorState<AB> {
}

let unsafe_head = *unsafe_head_rx.borrow();
let l1_origin = self.origin_selector.next_l1_origin(unsafe_head).await?;
let l1_origin = match self.origin_selector.next_l1_origin(unsafe_head).await {
Ok(l1_origin) => l1_origin,
Err(err) => {
warn!(
target: "sequencer",
?err,
"Temporary error occurred while selecting next L1 origin. Re-attempting on next tick."
);
return Ok(())
}
};
Comment on lines +164 to +174
Copy link
Copy Markdown
Contributor Author

@clabby clabby Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we don't really make a difference between what errors returned by the L1 origin selector are temporary vs. which aren't. The sequencer should always assume that transient RPC errors will recover.


if unsafe_head.l1_origin.hash != l1_origin.parent_hash &&
unsafe_head.l1_origin.hash != l1_origin.hash
Expand Down
2 changes: 1 addition & 1 deletion crates/node/service/src/actors/sequencer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! The `SequencerActor` and its components.

mod origin_selector;
pub use origin_selector::{L1OriginSelector, L1OriginSelectorError};
pub use origin_selector::{L1OriginSelector, L1OriginSelectorError, L1OriginSelectorProvider};

mod actor;
pub use actor::{
Expand Down
Loading