This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(node/service): L1OriginSelector advancement#2404
Merged
Conversation
clabby
requested review from
emhane,
refcell,
sadiq1971 and
theochap
as code owners
clabby
added
A-node
clabby
commented
Jul 14, 2025
Comment on lines
+164
to
+174
| let l1_origin = match self.origin_selector.next_l1_origin(unsafe_head).await { | ||
| Ok(l1_origin) => l1_origin, | ||
| Err(err) => { | ||
| warn!( | ||
| target: "sequencer", | ||
| ?err, | ||
| "Temporary error occurred while selecting next L1 origin. Re-attempting on next tick." | ||
| ); | ||
| return Ok(()) | ||
| } | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Note that we don't really make a difference between what errors returned by the L1 origin selector are temporary vs. which aren't. The sequencer should always assume that transient RPC errors will recover.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clabby
force-pushed
the
cl/l1-origin-selector
branch
from
55d4dc4 to
c7ac4ba
Compare
theochap
reviewed
Jul 14, 2025
theochap
reviewed
Jul 14, 2025
| if next_l1_origin_available { current_epoch + 1 } else { current_epoch }; | ||
| assert_eq!(next.hash, B256::with_last_byte(expected_epoch as u8)); | ||
| assert_eq!(next.number, expected_epoch); | ||
| } |
Member
There was a problem hiding this comment.
These tests are really great and I think we could get pretty high returns on having a few data structures like the MockOriginSelectorProvider in a common test crate to reuse to test the remaining actors
## Overview Adds in the logic for the `L1OriginSelector` to optimistically advance the origin based on the latest L1 block number, while allowing for transient failures to be retried. Also adds testing for the selector logic.
clabby
force-pushed
the
cl/l1-origin-selector
branch
from
c7ac4ba to
2ab4204
Compare
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Adds in the logic for the `L1OriginSelector` to optimistically advance the origin based on the latest L1 block number, while allowing for transient failures to be retried. Also adds testing for the selector logic. closes op-rs/kona#2245
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Overview Adds in the logic for the `L1OriginSelector` to optimistically advance the origin based on the latest L1 block number, while allowing for transient failures to be retried. Also adds testing for the selector logic. closes #2245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds in the logic for the
L1OriginSelectorto optimistically advance the origin based on the latest L1 block number, while allowing for transient failures to be retried.Also adds testing for the selector logic.
closes #2245