This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(node): Propagate engine reset to pipeline#1789
Merged
Conversation
clabby
added
A-node
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR propagates the engine reset to the derivation pipeline by integrating a reset call during engine initialization and extending reset signal handling in the pipeline. Key changes include:
- Propagation of L1 RPC URL and integration of engine reset in the engine launcher.
- Enhanced signal handling in the derivation actor to manage reset requests.
- Updates to the engine task queue, client API, and error type definitions, along with the removal of unused unknowns utilities.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/node/service/src/service/standard/builder.rs | Propagates the L1 RPC URL to the EngineLauncher. |
| crates/node/service/src/actors/engine.rs | Integrates the engine reset call during initialization and updates error handling. |
| crates/node/service/src/actors/derivation.rs | Reorders select! branches to improve reset signal handling and removes duplicate signal handling. |
| crates/node/engine/src/task_queue/tasks/unknowns.rs | Removes the unused unknowns initialization utilities. |
| crates/node/engine/src/task_queue/tasks/task.rs | Updates error type definitions for improved thread safety. |
| crates/node/engine/src/task_queue/tasks/forkchoice/task.rs | Modifies forkchoice update to trigger optimistic pipeline synchronization. |
| crates/node/engine/src/task_queue/core.rs | Introduces an async reset function to reorg the execution layer using a new starting forkchoice. |
| crates/node/engine/src/client.rs | Updates EngineClient to separately handle L1 and L2 providers. |
| crates/node/engine/Cargo.toml | Adds the kona-sources workspace dependency. |
Comments suppressed due to low confidence (1)
crates/node/service/src/actors/engine.rs:154
- Avoid using 'expect' for handling errors during engine reset. Consider returning a proper error to handle failures gracefully in production.
.await.expect("TODO: Handled in follow-up PR");
clabby
commented
May 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
refcell
approved these changes
May 16, 2025
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Small comments, none are strict blockers. This looks great
Co-Authored-By: theo <80177219+theochap@users.noreply.github.com>
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Builds on op-rs/kona#1771, adding support for propagating the engine reset back to the derivation pipeline. Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Overview Builds on #1771, adding support for propagating the engine reset back to the derivation pipeline. Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Builds on #1771, adding support for propagating the engine reset back to the derivation pipeline.