This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Closed
Conversation
refcell
reviewed
May 14, 2025
| // If the local safe head is not set, set it to the safe head. | ||
| self.state.set_local_safe_head(self.state.safe_head); | ||
|
|
||
| self.state.forkchoice_update_needed = true; |
Contributor
There was a problem hiding this comment.
This shouldn't be needed - setting the safe head via the set_safe_head method above will also set the forkchoice_update_needed = true
Contributor
|
closing in favor of #1789, which extends this. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2025
## Overview Builds on #1771, adding support for propagating the engine reset back to the derivation pipeline. Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Builds on op-rs/kona#1771, adding support for propagating the engine reset back to the derivation pipeline. Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.