Add decrypt support. #241
Merged
Add decrypt support. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pitbulk
commented
Jun 11, 2015
pitbulk
commented
- Be able to decrypt EncryptedAssertions
This was referenced Jun 11, 2015
Closed
|
To end the PR, I need to add support for EncryptedID (Encrypted NameID). meanwhile, @luisvm and @Lordnibbler can you review those commits? |
| @@ -51,6 +53,21 @@ def initialize(response, options = {}) | |||
|
|
|||
| @response = decode_raw_saml(response) | |||
| @document = XMLSecurity::SignedDocument.new(@response, @errors) | |||
|
|
|||
| if assertion_encrypted? | |||
There was a problem hiding this comment.
return unless assertion_encrypted?
...that will save you from indenting the following lines
|
👍 looks good. |
| assert_equal "true", spsso_descriptor.attribute("AuthnRequestsSigned").value | ||
| assert_equal ruby_saml_cert.to_der, cert.to_der | ||
| end | ||
|
|
||
| it "generates Service Provider Metadata with X509Certificate for sign and encrypt" do | ||
| assert_equal 2, key_descriptors.length |
There was a problem hiding this comment.
if there were 3... would that change anything in this spec? otherwise, we don't need the line
There was a problem hiding this comment.
We testing that there are 2 and only 2 key descriptors.
|
@pitbulk please look at the conversation, some of them doesn't make sense, so please tell me if I'm thinking it wrong :) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.