Decrypt support #193
Closed
Decrypt support #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lordnibbler what do you think about this PR? Please review, after that I plan to merge it in my branch and then publish it. |
| @@ -184,8 +195,8 @@ def validate_response_state(soft = true) | |||
| end | |||
|
|
|||
| def xpath_first_from_signed_assertion(subelt=nil) | |||
| node = REXML::XPath.first(document, "/p:Response/a:Assertion[@ID='#{document.signed_element_id}']#{subelt}", { "p" => PROTOCOL, "a" => ASSERTION }) | |||
| node ||= REXML::XPath.first(document, "/p:Response[@ID='#{document.signed_element_id}']/a:Assertion#{subelt}", { "p" => PROTOCOL, "a" => ASSERTION }) | |||
| node = REXML::XPath.first(assertion_document, "/samlp:Response/saml:Assertion[@ID='#{assertion_document.signed_element_id}']#{subelt}", { "samlp" => PROTOCOL, "saml" => ASSERTION, 'ds' => DSIG }) | |||
There was a problem hiding this comment.
this change does not incorporate the security fix from 0.8.2
Rebase off master and resolve the conflict, and I can re-review
|
I'd recommend we add documentation and tests for each new method added in |
|
Replaced by #241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial decrypt support. Related to #9