Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding supported for Encrypted SAML #196

Closed
wants to merge 10 commits into from

Conversation

ksinkar
Copy link

@ksinkar ksinkar commented Feb 19, 2015

These changes are for adding support for encrypted SAML messages. xmlenc from has been used for encryption and decryption. All existing tests for ruby-saml are passing. I had to upgrade the timecop gem though, for the tests to pass on my local machine. Unfortunately these are failing on Travis CI for REE and 1.8.x

@buffym @googya, could you please check and let me know if this works for your cases of Ping Federate and Encryption otherwise.
#9 #193 #186 #172

Now we propertly extract the Decrypted assertion using XPath (Nokogiri)
instead of using String Manipulation as was recorded earlier
Tests were failing for the Time based tests.
Upgrading the version of Timecop solved the issue.
The gemspec now conditionally loads different versions
of timecop depending on  the version of ruby
@pitbulk
Copy link
Collaborator

pitbulk commented Feb 19, 2015

Thanks @ksinkar, we will review all this code.
Notice that we already created a branch with some decrypt functionality.

We will integrate in the ruby-saml gem the encrypt/decrypt functionality for sure.

@ksinkar
Copy link
Author

ksinkar commented Feb 25, 2015

@pitbulk, I had a look at the decrypt branch in which you are developing the decrypt functionality. It seems that branch is only able to handle checking of signatures for encrypted assertions. I don't see any code for decrypting the encrypted assertions.

Please correct me if I am wrong in the above inference.

I am eager to get the decryption functionality into this gem. People have been asking for this functionality for quite some time now. I suggest that you merge my changes into master or the decrypt branch as you see fit. As for the failing tests, it is dependency problem of nokogiri which I have tried to solve by updating the xmlenc gemspec as well, but not yet been able to solve it. If you have any ideas please let me know and I shall solve them pronto.

@pitbulk
Copy link
Collaborator

pitbulk commented Feb 25, 2015

@pitbulk
Copy link
Collaborator

pitbulk commented Jun 11, 2015

Replaced by #241. Right now we avoid the use of xmlenc.

@pitbulk pitbulk closed this Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants