Unpin fsspec in dev requirements #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in fsspec led to growing numbers of "../.." entries at the end of the filepaths. A call to resolve() is always needed in order to keep the file paths canonical.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 85.02% 85.06% +0.03%
==========================================
Files 13 13
Lines 1529 1533 +4
==========================================
+ Hits 1300 1304 +4
Misses 229 229 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #338 I noticed that
fsspechas been (accidentally??) pinned in the tests. Opening this PR to demonstrate that when it's unpinned the tests fail, indicating incompatibility with more recent versions offsspec.