Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading HCS datasets at cloud paths https://github.com/ome/ome-zarr-py/issues/321 #322

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

elyall
Copy link
Contributor

@elyall elyall commented Oct 28, 2023

Solves being unable to load HCS datasets on S3, GCP, or Azure, see this issue: #321.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
ome_zarr/io.py 81.81% <25.00%> (-1.95%) ⬇️

📢 Thoughts on this report? Let us know!.

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/should-it-be-possible-to-load-an-ome-zarr-hcs-plate-directly-from-s3/86956/6

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested successfully at #321 (comment)

@joshmoore joshmoore merged commit 90b5ff9 into ome:master Nov 13, 2023
12 checks passed
@will-moore
Copy link
Member

@elyall Thanks for your contribution. It's included in the 0.8.3 release of ome-zarr-py today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants