[Forwardport] Module Catalog: fix issue with custom option price conversion for different base currency on website level#1
Closed
oleksii-lisovyi wants to merge 140 commits into2.3-developfrom
Closed
Conversation
- Added *.phtml files to exclusion list for PSR2 end tag static test.
…:upgrade attributes
…:upgrade attributes
…:upgrade attributes
…:upgrade attributes
…:upgrade attributes
…:upgrade attributes
…:upgrade attributes
…:upgrade attributes
…:upgrade attributes
- update regex in integration tests - skip MTF test
- fix setup for disabled modules
- add to CPD blacklist
Fix CE integration and static tests on Magento + MSI
…to-engcom/magento2ce into ENGCOM-2948-magento-graphql-ce-132
…beta_bugs [honey] MAGETWO-91034: Renaming of new setup commands and setup:install/setup:upgrade attributes
Accepted Public Pull Requests: - magento#18142: Replace intval() function by using direct type casting to (int) where no default value is needed (by @mage2pratik) - magento#18136: [2.3] Update labels section in README.md (by @sidolov) - magento#18117: Change sort order for customer group options (by @dmytro-ch) - magento#18102: Replace sort callbacks to spaceship operator (by @mage2pratik) - magento-commerce/async-import#15: add support HTTP DELETE method for async bulk request by adding mergi� (by @anvasiliev) Fixed GitHub Issues: - magento#18101: Wrong sort order for customer groups in customer grid filter (reported by @sreichel) has been fixed in magento#18117 by @dmytro-ch in 2.3-develop branch Related commits: 1. 568fa46 2. ed99490
- merged latest code from mainline branch
[epam] MAGETWO-95105: [2.3] URL Key column with accented characters not converted after importing the CSV file
[Qwerty] Bugfixes
- merged latest code from mainline branch
[EngCom] Public Pull Requests - GraphQL
…ferent base currency on website level
oleksii-lisovyi
force-pushed
the
2.3-develop-PR-port-18225
branch
from
baf7a34 to
4719a6e
Compare
engcom-Kilo
pushed a commit
that referenced
this pull request
Aug 17, 2020
Merge changes from origin repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#18225
Description
Issue is connected to the custom option price conversion based on base currency configured on default level, but not on website level (Magento allows to configure different base currency on website level according to documentation).
It's reproduced on the following Magento setup with multi-currency configuration:
Fixed Issues (if relevant)
No related issues found.
Manual testing scenarios
Steps to reproduce
Expected result
Custom option value price is not changed, because no actual changes were done.
Actual result
Custom option value price is updated according to USD/CAD currency rate.
Contribution checklist